Upgrade AWS SDK to v1.12.746#122431
Merged
elasticsearchmachine merged 6 commits intoelastic:mainfrom Feb 17, 2025
Merged
Conversation
elasticsearchmachine
added
needs:triage
alex-kattathra-johnson
force-pushed
the
fixes-98201
branch
3 times, most recently
from
a6a0678 to
3fe7b92
Compare
alex-kattathra-johnson
force-pushed
the
fixes-98201
branch
3 times, most recently
from
8daf5ab to
afada68
Compare
Signed-off-by: Alex Kattathra Johnson <ajohnson@360privacy.io>
alex-kattathra-johnson
force-pushed
the
fixes-98201
branch
from
afada68 to
7a5859f
Compare
limotova
added
:Distributed/Snapshot/Restore
elasticsearchmachine
added
the
Team:Distributed Coordination (obsolete)
Collaborator
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
Contributor
|
We are in the process of upgrading to v2. #122062 @DaveCTurner, should we wait for v2 or it's ok to bump v1 patch version? |
Contributor
|
I see no problems with upgrading this SDK version, even though it will eventually (hopefully soon) be replaced by a similarly-new-and-featureful v2. |
DaveCTurner
added
>upgrade
v8.19.0
v9.0.1
auto-backport
DaveCTurner
changed the title
DaveCTurner
added
the
auto-merge-without-approval
Contributor
|
@elasticmachine ok to test |
DaveCTurner
approved these changes
Feb 17, 2025
Contributor
DaveCTurner
left a comment
DaveCTurner
left a comment
There was a problem hiding this comment.
LGTM (assuming CI is happy)
breskeby
approved these changes
Feb 17, 2025
Contributor
|
@elasticmachine test this please |
Contributor
|
@elasticmachine test this please |
Contributor
|
@elasticmachine test this please |
DaveCTurner
pushed a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Feb 17, 2025
DaveCTurner
pushed a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Feb 17, 2025
Collaborator
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 17, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 17, 2025
ywangd
added a commit
to ywangd/elasticsearch
that referenced
this pull request
Feb 18, 2025
When a CopmleteMultipartUpload request fails after the initial 200 response, the status code of the failure response use to be not set and hence got translated to status code 0. With elastic#116212, we handle this case accordingly. Since AWS SDK 1.12.691, the status code is now set to 200 instead of 0. This PR changes our error handling code accordingly. Relates: elastic#122431 Relates: elastic#116212 Relevant AWS SDK change https://github.com/aws/aws-sdk-java/blame/430899c217f34fae63b35c77f4d9bfd361c9de77/aws-java-sdk-s3/src/main/java/com/amazonaws/services/s3/AmazonS3Client.java#L3696-L3709
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 18, 2025
When a CopmleteMultipartUpload request fails after the initial 200 response, the status code of the failure response use to be not set and hence got translated to status code 0. With #116212, we handle this case accordingly. Since AWS SDK 1.12.691, the status code is now set to 200 instead of 0. This PR changes our error handling code accordingly. Relates: #122431 Relates: #116212 Resolves: #122799 Relevant AWS SDK change https://github.com/aws/aws-sdk-java/blame/430899c217f34fae63b35c77f4d9bfd361c9de77/aws-java-sdk-s3/src/main/java/com/amazonaws/services/s3/AmazonS3Client.java#L3696-L3709
ywangd
added a commit
to ywangd/elasticsearch
that referenced
this pull request
Feb 18, 2025
When a CopmleteMultipartUpload request fails after the initial 200 response, the status code of the failure response use to be not set and hence got translated to status code 0. With elastic#116212, we handle this case accordingly. Since AWS SDK 1.12.691, the status code is now set to 200 instead of 0. This PR changes our error handling code accordingly. Relates: elastic#122431 Relates: elastic#116212 Resolves: elastic#122799 Relevant AWS SDK change https://github.com/aws/aws-sdk-java/blame/430899c217f34fae63b35c77f4d9bfd361c9de77/aws-java-sdk-s3/src/main/java/com/amazonaws/services/s3/AmazonS3Client.java#L3696-L3709 (cherry picked from commit 850249b) # Conflicts: # muted-tests.yml
ywangd
added a commit
to ywangd/elasticsearch
that referenced
this pull request
Feb 18, 2025
When a CopmleteMultipartUpload request fails after the initial 200 response, the status code of the failure response use to be not set and hence got translated to status code 0. With elastic#116212, we handle this case accordingly. Since AWS SDK 1.12.691, the status code is now set to 200 instead of 0. This PR changes our error handling code accordingly. Relates: elastic#122431 Relates: elastic#116212 Resolves: elastic#122799 Relevant AWS SDK change https://github.com/aws/aws-sdk-java/blame/430899c217f34fae63b35c77f4d9bfd361c9de77/aws-java-sdk-s3/src/main/java/com/amazonaws/services/s3/AmazonS3Client.java#L3696-L3709 (cherry picked from commit 850249b) # Conflicts: # muted-tests.yml
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 18, 2025
* Handle status code 200 for s3 CMU response (#122815) When a CopmleteMultipartUpload request fails after the initial 200 response, the status code of the failure response use to be not set and hence got translated to status code 0. With #116212, we handle this case accordingly. Since AWS SDK 1.12.691, the status code is now set to 200 instead of 0. This PR changes our error handling code accordingly. Relates: #122431 Relates: #116212 Resolves: #122799 Relevant AWS SDK change https://github.com/aws/aws-sdk-java/blame/430899c217f34fae63b35c77f4d9bfd361c9de77/aws-java-sdk-s3/src/main/java/com/amazonaws/services/s3/AmazonS3Client.java#L3696-L3709 (cherry picked from commit 850249b) # Conflicts: # muted-tests.yml * unmute
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 19, 2025
When a CopmleteMultipartUpload request fails after the initial 200 response, the status code of the failure response use to be not set and hence got translated to status code 0. With #116212, we handle this case accordingly. Since AWS SDK 1.12.691, the status code is now set to 200 instead of 0. This PR changes our error handling code accordingly. Relates: #122431 Relates: #116212 Resolves: #122799 Relevant AWS SDK change https://github.com/aws/aws-sdk-java/blame/430899c217f34fae63b35c77f4d9bfd361c9de77/aws-java-sdk-s3/src/main/java/com/amazonaws/services/s3/AmazonS3Client.java#L3696-L3709 (cherry picked from commit 850249b) # Conflicts: # muted-tests.yml Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Contributor
Author
|
@DaveCTurner Do we have an ETA on the 8.19.0 release? |
Contributor
|
Sorry @alex-kattathra-johnson, no hard plans for 8.19.0 yet - we haven't even released 8.18.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.