Run TransportGetDataStreamsAction on local node#122852
Merged
nielsbauman merged 7 commits intoelastic:mainfrom Mar 13, 2025
Merged
Run TransportGetDataStreamsAction on local node#122852nielsbauman merged 7 commits intoelastic:mainfrom
TransportGetDataStreamsAction on local node#122852nielsbauman merged 7 commits intoelastic:mainfrom
Conversation
This action solely needs the cluster state, it can run on any node. Additionally, it needs to be cancellable to avoid doing unnecessary work after a client failure or timeout. Relates elastic#101805
nielsbauman
added
>enhancement
:StorageEngine/Data streams
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
Collaborator
|
Hi @nielsbauman, I've created a changelog YAML for you. |
nielsbauman
commented
Feb 18, 2025
...a-streams/src/test/java/org/elasticsearch/datastreams/action/GetDataStreamsRequestTests.java
Outdated
Show resolved
Hide resolved
dakrone
approved these changes
Mar 3, 2025
Member
dakrone
left a comment
dakrone
left a comment
There was a problem hiding this comment.
LGTM, I left a couple of comments
...ternalClusterTest/java/org/elasticsearch/datastreams/DataStreamRestActionCancellationIT.java
Show resolved
Hide resolved
...treams/src/main/java/org/elasticsearch/datastreams/action/TransportGetDataStreamsAction.java
Show resolved
Hide resolved
...a-streams/src/test/java/org/elasticsearch/datastreams/action/GetDataStreamsRequestTests.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/action/datastreams/GetDataStreamAction.java
Show resolved
Hide resolved
45 tasks
nielsbauman
added a commit
that referenced
this pull request
Mar 18, 2025
These tests had the potential to fail when two consecutive GET data streams requests would hit two different nodes, where one node already had the cluster state that contained the new backing index and the other node didn't yet. Caused by #122852
nielsbauman
added a commit
that referenced
this pull request
Mar 19, 2025
These tests had the potential to fail when two consecutive GET data streams requests would hit two different nodes, where one node already had the cluster state that contained the new backing index and the other node didn't yet. Caused by #122852
nielsbauman
added a commit
to nielsbauman/elasticsearch
that referenced
this pull request
Mar 19, 2025
These tests had the potential to fail when two consecutive GET data streams requests would hit two different nodes, where one node already had the cluster state that contained the new backing index and the other node didn't yet. Caused by elastic#122852 Fixes elastic#124846 Fixes elastic#124950 Fixes elastic#124999
nielsbauman
added a commit
to nielsbauman/elasticsearch
that referenced
this pull request
Mar 25, 2025
These tests had the potential to fail when two consecutive GET data streams requests would hit two different nodes, where one node already had the cluster state that contained the new backing index and the other node didn't yet. Caused by elastic#122852 Fixes elastic#124837 Fixes elastic#124849 Fixes elastic#124850 Fixes elastic#124886 Fixes elastic#125083
nielsbauman
added a commit
to nielsbauman/elasticsearch
that referenced
this pull request
Mar 25, 2025
These tests had the potential to fail when two consecutive GET data streams requests would hit two different nodes, where one node already had the cluster state that contained the new backing index and the other node didn't yet. Caused by elastic#122852 Fixes elastic#124882 Fixes elastic#124885
nielsbauman
added a commit
to nielsbauman/elasticsearch
that referenced
this pull request
Mar 25, 2025
This test had the potential to fail when two consecutive GET data streams requests would hit two different nodes, where one node already had the cluster state that contained the new backing index and the other node didn't yet. Caused by elastic#122852 Fixes elastic#124987
nielsbauman
added a commit
that referenced
this pull request
Mar 26, 2025
…#125609) These tests had the potential to fail when two consecutive GET data streams requests would hit two different nodes, where one node already had the cluster state that contained the new backing index and the other node didn't yet. Caused by #122852 Fixes #124837 Fixes #124849 Fixes #124850 Fixes #124886 Fixes #125083
nielsbauman
added a commit
to nielsbauman/elasticsearch
that referenced
this pull request
Mar 26, 2025
…tyIT` This test seemed to fail because we would index another document before the master processed the data stream rollover - which is possible because non-master nodes expose the next cluster state a little bit earlier than the master node. Caused by elastic#122852 Fixes elastic#124978
omricohenn
pushed a commit
to omricohenn/elasticsearch
that referenced
this pull request
Mar 28, 2025
…125195) These tests had the potential to fail when two consecutive GET data streams requests would hit two different nodes, where one node already had the cluster state that contained the new backing index and the other node didn't yet. Caused by elastic#122852 Fixes elastic#124846 Fixes elastic#124950 Fixes elastic#124999
omricohenn
pushed a commit
to omricohenn/elasticsearch
that referenced
this pull request
Mar 28, 2025
…125611) These tests had the potential to fail when two consecutive GET data streams requests would hit two different nodes, where one node already had the cluster state that contained the new backing index and the other node didn't yet. Caused by elastic#122852 Fixes elastic#124882 Fixes elastic#124885
omricohenn
pushed a commit
to omricohenn/elasticsearch
that referenced
this pull request
Mar 28, 2025
This test had the potential to fail when two consecutive GET data streams requests would hit two different nodes, where one node already had the cluster state that contained the new backing index and the other node didn't yet. Caused by elastic#122852 Fixes elastic#124987
omricohenn
pushed a commit
to omricohenn/elasticsearch
that referenced
this pull request
Mar 28, 2025
…elastic#125609) These tests had the potential to fail when two consecutive GET data streams requests would hit two different nodes, where one node already had the cluster state that contained the new backing index and the other node didn't yet. Caused by elastic#122852 Fixes elastic#124837 Fixes elastic#124849 Fixes elastic#124850 Fixes elastic#124886 Fixes elastic#125083
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This action solely needs the cluster state, it can run on any node. Additionally, it needs to be cancellable to avoid doing unnecessary work after a client failure or timeout.
Relates #101805