Improved error message when index field type is unknown

[Samiul-TheSoccerFan]

Response with better error message if an index field type is invalid or unknown.

PUT index1
{
  "mappings": {
    "properties": {
      "content": {
        "type": "text1"
      }
    }
  }
}

will now return the updated error message:

{
  "error": {
    "root_cause": [
      {
        "type": "mapper_parsing_exception",
        "reason": "The mapper type [text1] does not exist. It might have been created within a future version or requires a plugin to be installed. Check the documentation."
      }
    ],
    "type": "mapper_parsing_exception",
    "reason": "Failed to parse mapping: The mapper type [text1] does not exist. It might have been created within a future version or requires a plugin to be installed. Check the documentation.",
    "caused_by": {
      "type": "mapper_parsing_exception",
      "reason": "The mapper type [text1] does not exist. It might have been created within a future version or requires a plugin to be installed. Check the documentation."
    }
  },
  "status": 400
}

[Samiul-TheSoccerFan]

Do we need to update the error message for these places too?

elasticsearch/server/src/main/java/org/elasticsearch/index/mapper/RuntimeField.java

Line 182 in a59c182

throw new MapperParsingException("No handler for type [" + type + "] declared on runtime field [" + fieldName + "]");

The error message can be reproduced with this:

PUT index6
{
  "mappings": {
    "runtime": {
      "day_of_week": {
        "type": "keyword1"
      }
    }
  }
}

elasticsearch/server/src/main/java/org/elasticsearch/index/mapper/TypeParsers.java

Line 164 in 4ef5ea6

throw new MapperParsingException("no handler for type [" + type + "] declared on field [" + multiFieldName + "]");

The error message can be reproduced with this:

PUT index8
{
  "mappings": {
    "properties": {
      "city": {
        "type": "text",
        "fields": {
          "raw": { 
            "type":  "keyword1"
          }
        }
      }
    }
  }
}

[elasticsearchmachine]

Hi @Samiul-TheSoccerFan, I've created a changelog YAML for you.

[Mikep86]

Good catch on the other places this error is thrown, we need to update those as well and add tests for those cases.

[Mikep86]

Also, it's important to note that we don't backport enhancements to released stack versions (or stack versions after FF). Only bug fixes are eligible for backporting.

[elasticsearchmachine]

Pinging @elastic/search-eng (Team:SearchOrg)

[elasticsearchmachine]

Pinging @elastic/search-relevance (Team:Search - Relevance)

[Mikep86]

@elasticmachine update branch

[Mikep86]

Looking a lot better! Just a couple small things to clean up.

[Samiul-TheSoccerFan]

@elasticmachine update branch

[Mikep86]

LGTM, thanks for the iterations!

[elasticsearchmachine]

💔 Backport failed

Status	Branch	Result
❌	8.x	Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 122860

[Mikep86]

@Samiul-TheSoccerFan Can you fix the backport PR?

[Samiul-TheSoccerFan]

💚 All backports created successfully

Status	Branch	Result
✅	8.x

Questions ?

Please refer to the Backport tool documentation