Fix geoip databases index access after system feature migration (again)#122938
Merged
joegallo merged 8 commits intoelastic:mainfrom Feb 21, 2025
Merged
Conversation
joegallo
added
>bug
:Distributed/Ingest Node
Collaborator
|
Hi @joegallo, I've created a changelog YAML for you. |
After migrating the system indices, the having .geoip_databases as an index-behind-an-alias ends up resulting in `GET _data_stream` blowing up.
such that a net new alias is visible if the net new index that it points to is visible.
joegallo
force-pushed
the
fix-geoip-access-after-reindex-repeat
branch
from
a16bc2f to
ffc82ff
Compare
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
Contributor
Author
|
This PR will close elastic/kibana#211102. |
gmarouli
approved these changes
Feb 21, 2025
Contributor
gmarouli
left a comment
gmarouli
left a comment
There was a problem hiding this comment.
LGTM, +1 for the comment :)
Contributor
Author
|
Dammit! I forgot the |
joegallo
added a commit
to joegallo/elasticsearch
that referenced
this pull request
Feb 21, 2025
joegallo
added a commit
to joegallo/elasticsearch
that referenced
this pull request
Feb 21, 2025
joegallo
added a commit
to joegallo/elasticsearch
that referenced
this pull request
Feb 21, 2025
This was referenced Feb 21, 2025
Merged
Merged
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 21, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 21, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up to #121196.
Once again I've added a failing integration test to capture the actual failing workflow that we noticed during testing, then I wrote a failing unit test to try to keep things a little tighter. Finally there's a small change to our index expression resolution code.
As before, the true root issue is that we're doing index resolution in two passes when X-Pack Security is enabled -- in the first pass we resolve the wildcard to whatever (in a security-aware manner) and then in the second pass the wildcards have been removed, so it's like we're asking for things literally by name. The error in this case was because the wildcard resolution was including the alias (only!), so the second round of resolution was blowing up and saying "don't ask for an alias here".
I'm fine with the tests I've written here, but I think it's obvious from my comments that I'm not entirely thrilled with my actual "solution" to this bug.