Hold store reference in InternalEngine#performActionWithDirectoryReader(...)#123010
Merged
martijnvg merged 2 commits intoelastic:mainfrom Feb 21, 2025
Merged
Conversation
…er(...) This method gets called from `InternalEngine#resolveDocVersion(...)`, which gets during indexing (via `InternalEngine.index(...)`). When `InternalEngine.index(...)` gets invoked, the InternalEngine only ensures that it holds a ref to the engine via Engine#acquireEnsureOpenRef(), but this doesn't ensure whether it holds a reference to the store. Closes elastic#122974
martijnvg
added
>bug
:Distributed/Engine
elasticsearchmachine
added
the
Team:Distributed Indexing (obsolete)
Collaborator
|
Hi @martijnvg, I've created a changelog YAML for you. |
Collaborator
|
Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing) |
Member
Author
|
Thanks for reviewing Tanguy! |
martijnvg
added
the
auto-backport
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Feb 24, 2025
…er(...) (elastic#123010) This method gets called from `InternalEngine#resolveDocVersion(...)`, which gets during indexing (via `InternalEngine.index(...)`). When `InternalEngine.index(...)` gets invoked, the InternalEngine only ensures that it holds a ref to the engine via Engine#acquireEnsureOpenRef(), but this doesn't ensure whether it holds a reference to the store. Closes elastic#122974 * Update docs/changelog/123010.yaml
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Feb 24, 2025
…er(...) (elastic#123010) This method gets called from `InternalEngine#resolveDocVersion(...)`, which gets during indexing (via `InternalEngine.index(...)`). When `InternalEngine.index(...)` gets invoked, the InternalEngine only ensures that it holds a ref to the engine via Engine#acquireEnsureOpenRef(), but this doesn't ensure whether it holds a reference to the store. Closes elastic#122974 * Update docs/changelog/123010.yaml
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 24, 2025
…er(...) (#123010) (#123241) This method gets called from `InternalEngine#resolveDocVersion(...)`, which gets during indexing (via `InternalEngine.index(...)`). When `InternalEngine.index(...)` gets invoked, the InternalEngine only ensures that it holds a ref to the engine via Engine#acquireEnsureOpenRef(), but this doesn't ensure whether it holds a reference to the store. Closes #122974 * Update docs/changelog/123010.yaml
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 24, 2025
…er(...) (#123010) (#123242) This method gets called from `InternalEngine#resolveDocVersion(...)`, which gets during indexing (via `InternalEngine.index(...)`). When `InternalEngine.index(...)` gets invoked, the InternalEngine only ensures that it holds a ref to the engine via Engine#acquireEnsureOpenRef(), but this doesn't ensure whether it holds a reference to the store. Closes #122974 * Update docs/changelog/123010.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This method gets called from
InternalEngine#resolveDocVersion(...), which gets during indexing (viaInternalEngine.index(...)).When
InternalEngine.index(...)gets invoked, the InternalEngine only ensures that it holds a ref to the engine via Engine#acquireEnsureOpenRef(), but this doesn't ensure whether it holds a reference to the store.Closes #122974