Allow skip shards with _tier and _index in ES|QL#123728
Merged
dnhatn merged 7 commits intoelastic:mainfrom Mar 1, 2025
Merged
Conversation
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
elasticsearchmachine
added
the
Team:Analytics
Collaborator
|
Hi @dnhatn, I've created a changelog YAML for you. |
dnhatn
requested review from
astefan,
idegtiarenko,
luigidellaquila and
nik9000
and removed request for
idegtiarenko and
nik9000
…t {p0=search.vectors/41_knn_search_bbq_hnsw/Test knn search} elastic#123727
dnhatn
force-pushed
the
more-can-match
branch
from
20ac10c to
1653556
Compare
costin
reviewed
Feb 28, 2025
|
|
||
| public static QueryBuilder canMatchFilter(PhysicalPlan plan) { | ||
| // metadata field like _index, _tier | ||
| return detectFilter(plan, f -> CAN_MATCH_FIELDS.contains(f) || f.startsWith("_")); |
Member
There was a problem hiding this comment.
this might pull in other fields starting with _ , such as _score or other user defined functions.
costin
approved these changes
Feb 28, 2025
Member
costin
left a comment
costin
left a comment
There was a problem hiding this comment.
LGTM. To what degree the filter inside can match though be generified?
Member
Author
|
Thanks Costin. I've updated the list of supported field names in 89b5ad9. |
dnhatn
added
the
auto-backport
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Mar 1, 2025
This change adds support for skipping shards with event.ingested fields and metadata fields (_tier, _index). This should allow ES|QL to skip unmatched shards and avoid sending requests to the data nodes.
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 1, 2025
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Mar 3, 2025
This change adds support for skipping shards with event.ingested fields and metadata fields (_tier, _index). This should allow ES|QL to skip unmatched shards and avoid sending requests to the data nodes. (cherry picked from commit cdd4df5)
dnhatn
added a commit
that referenced
this pull request
Mar 3, 2025
This change adds support for skipping shards with event.ingested fields and metadata fields (_tier, _index). This should allow ES|QL to skip unmatched shards and avoid sending requests to the data nodes. (cherry picked from commit cdd4df5)
This was referenced Mar 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds support for skipping shards with
event.ingestedfields and metadata fields (_tier, _index). This should allow ES|QL to skip unmatched shards and avoid sending requests to the data nodes.