Handle long overflow in dates#124048
Merged
smalyshev merged 21 commits intoelastic:mainfrom Mar 26, 2025
Merged
Conversation
smalyshev
added
:StorageEngine/Mapping
Collaborator
|
Hi @smalyshev, I've created a changelog YAML for you. |
elasticsearchmachine
added
Team:StorageEngine
Team:Search Foundations
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
Collaborator
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
smalyshev
removed
Team:StorageEngine
:StorageEngine/Mapping
smalyshev
force-pushed
the
fix-date-112483
branch
from
35b41dd to
3456bbd
Compare
smalyshev
added
the
auto-backport
Contributor
|
This fix seems to be linked as well with #125321 , can you double check? |
Contributor
Author
|
@javanna Unfortunately I can't reproduce the issue as described in #125321 but if somehow |
mosche
approved these changes
Mar 26, 2025
Contributor
mosche
left a comment
mosche
left a comment
There was a problem hiding this comment.
lgtm from a core/infra perspective 👍
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
smalyshev
added a commit
to smalyshev/elasticsearch
that referenced
this pull request
Mar 26, 2025
* Handle long overflow in dates (cherry picked from commit 07921a7) # Conflicts: # rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/search/500_date_range.yml # server/src/main/java/org/elasticsearch/index/mapper/DateFieldMapper.java # server/src/main/java/org/elasticsearch/index/mapper/MapperFeatures.java
smalyshev
added a commit
to smalyshev/elasticsearch
that referenced
this pull request
Mar 26, 2025
* Handle long overflow in dates (cherry picked from commit 07921a7) # Conflicts: # server/src/main/java/org/elasticsearch/index/mapper/DateFieldMapper.java # server/src/main/java/org/elasticsearch/index/mapper/MapperFeatures.java
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
smalyshev
added a commit
to smalyshev/elasticsearch
that referenced
this pull request
Mar 26, 2025
* Handle long overflow in dates (cherry picked from commit 07921a7) # Conflicts: # rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/search/500_date_range.yml # server/src/main/java/org/elasticsearch/index/mapper/DateFieldMapper.java # server/src/main/java/org/elasticsearch/index/mapper/MapperFeatures.java
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 26, 2025
* Handle long overflow in dates (#124048) * Handle long overflow in dates (cherry picked from commit 07921a7) # Conflicts: # rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/search/500_date_range.yml # server/src/main/java/org/elasticsearch/index/mapper/DateFieldMapper.java # server/src/main/java/org/elasticsearch/index/mapper/MapperFeatures.java * Add import
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 26, 2025
* Handle long overflow in dates (#124048) * Handle long overflow in dates (cherry picked from commit 07921a7) # Conflicts: # rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/search/500_date_range.yml # server/src/main/java/org/elasticsearch/index/mapper/DateFieldMapper.java # server/src/main/java/org/elasticsearch/index/mapper/MapperFeatures.java * Add import
omricohenn
pushed a commit
to omricohenn/elasticsearch
that referenced
this pull request
Mar 28, 2025
* Handle long overflow in dates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes sure that dates that overflow a long fail with a reasonable message rather than an ArithmeticException. This mostly just hits the field mapper.
Update on #112650
Fixes #112483