ESQL: Lazy collection copying during node transform#124424
Merged
costin merged 4 commits intoelastic:mainfrom Mar 10, 2025
Merged
ESQL: Lazy collection copying during node transform#124424costin merged 4 commits intoelastic:mainfrom
costin merged 4 commits intoelastic:mainfrom
Conversation
A set of optimization for tree traversal: 1. perform lazy copying during children transform 2. use long hashing to avoid object creation 3. perform type check first before collection checking Relates elastic#124395
elasticsearchmachine
added
the
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
Collaborator
|
Hi @costin, I've created a changelog YAML for you. |
costin
added
v8.19.0
v8.18.1
auto-backport
Collaborator
costin
added a commit
to costin/elasticsearch
that referenced
this pull request
Mar 10, 2025
* ESQL: Lazy collection copying during node transform A set of optimization for tree traversal: 1. perform lazy copying during children transform 2. use long hashing to avoid object creation 3. perform type check first before collection checking Relates elastic#124395
costin
added a commit
to costin/elasticsearch
that referenced
this pull request
Mar 10, 2025
* ESQL: Lazy collection copying during node transform A set of optimization for tree traversal: 1. perform lazy copying during children transform 2. use long hashing to avoid object creation 3. perform type check first before collection checking Relates elastic#124395
costin
added a commit
to costin/elasticsearch
that referenced
this pull request
Mar 10, 2025
* ESQL: Lazy collection copying during node transform A set of optimization for tree traversal: 1. perform lazy copying during children transform 2. use long hashing to avoid object creation 3. perform type check first before collection checking Relates elastic#124395
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 11, 2025
* ESQL: Lazy collection copying during node transform A set of optimization for tree traversal: 1. perform lazy copying during children transform 2. use long hashing to avoid object creation 3. perform type check first before collection checking Relates #124395
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 11, 2025
* ESQL: Lazy collection copying during node transform A set of optimization for tree traversal: 1. perform lazy copying during children transform 2. use long hashing to avoid object creation 3. perform type check first before collection checking Relates #124395
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 11, 2025
* ESQL: Lazy collection copying during node transform A set of optimization for tree traversal: 1. perform lazy copying during children transform 2. use long hashing to avoid object creation 3. perform type check first before collection checking Relates #124395
georgewallace
pushed a commit
to georgewallace/elasticsearch
that referenced
this pull request
Mar 11, 2025
* ESQL: Lazy collection copying during node transform A set of optimization for tree traversal: 1. perform lazy copying during children transform 2. use long hashing to avoid object creation 3. perform type check first before collection checking Relates elastic#124395
15 tasks
alex-spies
reviewed
Mar 11, 2025
Contributor
alex-spies
left a comment
alex-spies
left a comment
There was a problem hiding this comment.
Heya, late to the party but the changes LGTM.
Maybe we should add a micro-benchmark or nightly track as one of the next steps, so we can make the difference in performance more visible.
|
|
||
| Function<Object, Object> realRule = p -> { | ||
| if (p != children && false == children.contains(p) && (p == null || typeToken.isInstance(p))) { | ||
| if (p != children && (p == null || typeToken.isInstance(p)) && false == children.contains(p)) { |
Contributor
There was a problem hiding this comment.
Thought: should the children.contains(p) still show up in profiles, we could maybe refactor NodeInfo to track the non-children properties separately - avoiding this check in the first place.
albertzaharovits
pushed a commit
to albertzaharovits/elasticsearch
that referenced
this pull request
Mar 13, 2025
* ESQL: Lazy collection copying during node transform A set of optimization for tree traversal: 1. perform lazy copying during children transform 2. use long hashing to avoid object creation 3. perform type check first before collection checking Relates elastic#124395
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
Mar 13, 2025
* ESQL: Lazy collection copying during node transform A set of optimization for tree traversal: 1. perform lazy copying during children transform 2. use long hashing to avoid object creation 3. perform type check first before collection checking Relates elastic#124395
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A set of optimization for tree traversal:
Relates #124395