Skip to content

Let MLTQuery throw IAE when no analyzer is set#124662

Merged
tteofili merged 5 commits intoelastic:mainfrom
tteofili:mlt_analyzer_iae
Mar 12, 2025
Merged

Let MLTQuery throw IAE when no analyzer is set#124662
tteofili merged 5 commits intoelastic:mainfrom
tteofili:mlt_analyzer_iae

Conversation

@tteofili
Copy link
Contributor

@tteofili tteofili commented Mar 12, 2025 •
edited
Loading

fixes #124562
@tteofili tteofili added >bug :Search Relevance/Search Catch all for Search Relevance labels Mar 12, 2025
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Mar 12, 2025

Hi @tteofili, I've created a changelog YAML for you.
@tteofili tteofili marked this pull request as ready for review March 12, 2025 16:14
@elasticsearchmachine elasticsearchmachine added the Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch label Mar 12, 2025
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Mar 12, 2025

Pinging @elastic/es-search-relevance (Team:Search Relevance)
iverase
iverase approved these changes Mar 12, 2025
View reviewed changes
Copy link
Contributor

@iverase iverase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@tteofili tteofili merged commit c971d79 into elastic:main Mar 12, 2025
17 checks passed
albertzaharovits pushed a commit to albertzaharovits/elasticsearch that referenced this pull request Mar 13, 2025
@tteofili @albertzaharovits
Let MLTQuery throw IAE when no analyzer is set (elastic#124662)
2217ce7 
* Let MLTQuery throw IAE when no analyzer is set
jfreden pushed a commit to jfreden/elasticsearch that referenced this pull request Mar 13, 2025
@tteofili @jfreden
Let MLTQuery throw IAE when no analyzer is set (elastic#124662)
8ec1074 
* Let MLTQuery throw IAE when no analyzer is set
@smalyshev
Copy link
Contributor

smalyshev commented Mar 19, 2025

Any reason why this wasn't backported to older versions? Looks like I am seeing some instances of suppressed REST errors from this.
tteofili added a commit to tteofili/elasticsearch that referenced this pull request Mar 19, 2025
@tteofili
Let MLTQuery throw IAE when no analyzer is set (elastic#124662)
f066d2c 
* Let MLTQuery throw IAE when no analyzer is set

(cherry picked from commit c971d79)
@tteofili tteofili mentioned this pull request Mar 19, 2025
Merged
tteofili added a commit to tteofili/elasticsearch that referenced this pull request Mar 19, 2025
@tteofili
Let MLTQuery throw IAE when no analyzer is set (elastic#124662)
0782dad 
* Let MLTQuery throw IAE when no analyzer is set

(cherry picked from commit c971d79)
tteofili added a commit that referenced this pull request Mar 19, 2025
@tteofili
Let MLTQuery throw IAE when no analyzer is set (#124662) (#125190)
e2a2564 
* Let MLTQuery throw IAE when no analyzer is set

(cherry picked from commit c971d79)
tteofili added a commit that referenced this pull request Mar 19, 2025
@tteofili
8.x branch backport for leting MLTQuery throw IAE when no analyzer is…
2ffd44b 
… set (#124662) (#125192)

* Let MLTQuery throw IAE when no analyzer is set (#124662)

(cherry picked from commit c971d79)
@tteofili
Copy link
Contributor Author

tteofili commented Mar 19, 2025

it's now been backported to 9.0 and 8.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>bug :Search Relevance/Search Catch all for Search Relevance Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v9.1.0

4 participants

@tteofili @elasticsearchmachine @smalyshev @iverase