Avoid creating known_fields for every check in Alias#124690
Merged
dakrone merged 5 commits intoelastic:mainfrom Mar 24, 2025
Merged
Avoid creating known_fields for every check in Alias#124690dakrone merged 5 commits intoelastic:mainfrom
dakrone merged 5 commits intoelastic:mainfrom
Conversation
elasticsearchmachine
added
needs:triage
fressi-elastic
added
the
:Data Management/Indices APIs
elasticsearchmachine
added
Team:Data Management (obsolete)
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
Contributor
Author
|
ping @fressi-elastic |
Member
|
buildkite test this |
omricohenn
pushed a commit
to omricohenn/elasticsearch
that referenced
this pull request
Mar 28, 2025
* avoid creating known_fields for every check * add changelog --------- Co-authored-by: 广富 <shaoqiong.msq@alibaba-inc.com> Co-authored-by: Lee Hinman <dakrone@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves KNOW_FIELDS creation out of fromXcontent method of Alias class and make it to be a static final field to avoid creating it for every check