Merged
Conversation
…ds-up rolling up gauges/counters.
martijnvg
added
>enhancement
:StorageEngine/Downsampling
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
Collaborator
|
Hi @martijnvg, I've created a changelog YAML for you. |
kkrik-es
reviewed
Mar 13, 2025
| case min -> min = Math.min(value, min); | ||
| case max -> max = Math.max(value, max); | ||
| case sum -> sum.add(value); | ||
| case value_count -> count += Math.round(value); |
Contributor
There was a problem hiding this comment.
Shouldn't this be count++ ?
Member
Author
There was a problem hiding this comment.
So this implementation is used only when rolling up downsampled indices. In that case we need to sum the value_count field of all aggregate metric double fields. I will add a comment to make this clearer.
kkrik-es
approved these changes
Mar 13, 2025
Contributor
kkrik-es
left a comment
kkrik-es
left a comment
There was a problem hiding this comment.
Just one comment, ptal.
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Mar 13, 2025
Remove unneeded Metric abstraction in MetricFieldProducer, which speeds-up rolling up gauges/counters.
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Mar 13, 2025
Remove unneeded Metric abstraction in MetricFieldProducer, which speeds-up rolling up gauges/counters.
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Mar 13, 2025
Remove unneeded Metric abstraction in MetricFieldProducer, which speeds-up rolling up gauges/counters.
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
Mar 13, 2025
Remove unneeded Metric abstraction in MetricFieldProducer, which speeds-up rolling up gauges/counters.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 13, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 13, 2025
martijnvg
added a commit
that referenced
this pull request
Mar 13, 2025
Backporting #124739 to 8.18 branch. Remove unneeded Metric abstraction in MetricFieldProducer, which speeds-up rolling up gauges/counters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove unneeded Metric abstraction in MetricFieldProducer, which speeds-up rolling up gauges/counters.