Pass IndexReshardingMetadata over the wire#124841
Conversation
When I introduced IndexReshardingMetadata I inadvertently only covered local serialization. It was not getting sent or received over the wire. This fixes that.
bcully
added
>bug
:Distributed/Distributed
elasticsearchmachine
added
the
Team:Distributed Indexing (obsolete)
|
Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing) |
|
Hi @bcully, I've created a changelog YAML for you. |
| } | ||
|
|
||
| @Override | ||
| public boolean equals(Object o) { |
There was a problem hiding this comment.
I wonder if we should add a check for the IndexReshardingMetadata being equal here.
There was a problem hiding this comment.
Thanks, this is a good point. It did get me to look at which fields are included and there are some others that are serialized but not included in equality comparison (e.g., timestampRange/eventIngestedRange) and I'm not sure I understand whether that's by design or an oversight. But it does seem like resharding metadata should be included regardless. I'll update.
| for (int i = 0; i < aliasCount; i++) { | ||
| builder.putAlias(randomAlias()); | ||
| } | ||
| if (randomBoolean()) { |
There was a problem hiding this comment.
Do we not need any compatibility checks in this test ?
There was a problem hiding this comment.
I was also wondering if we have a cluster where the master node is on a different (older) version and the data node that initiates the reshard is on a newer version, how do we handle that ?
There was a problem hiding this comment.
I was also wondering if we have a cluster where the master node is on a different (older) version and the data node that initiates the reshard is on a newer version, how do we handle that ?
I think we should check at the top of an autoshard action if the cluster-wide minimum version is too low to parse resharding metadata, and fail immediately if so. I don't think it goes in this change though.
There was a problem hiding this comment.
Do we not need any compatibility checks in this test ?
I haven't found BWC tests for the other fields that are conditionally serialized, but it does seem like a good idea. I'll add something.
Also add a basic BWC serialization test for resharding metadata.
…hardingMetadata-OnTheWire
…hardingMetadata-OnTheWire
…hardingMetadata-OnTheWire
server/src/main/java/org/elasticsearch/cluster/metadata/IndexMetadata.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/cluster/metadata/IndexMetadata.java
Outdated
Show resolved
Hide resolved
* Pass IndexReshardingMetadata over the wire When I introduced IndexReshardingMetadata I inadvertently only covered local serialization. It was not getting sent or received over the wire. This fixes that.
4 participants
When I introduced IndexReshardingMetadata I inadvertently only covered local serialization. It was not getting sent or received over the wire. This fixes that.