Merged
Conversation
The JVM has a couple ways that Java options can be passed. In Elasticsearch we ignore these common patterns, instead using our own bespoke mechanisms for setting options (ES_JAVA_OPTS, etc). The primary reason for this is some systems like Ubuntu setting these options globally and then affecting Elasticsearch, often in ways that cause Elasticsearch to fail to start. This commit ignores _JAVA_OPTIONS, which is a little known environment variable that the JVM may pick up options from.
rjernst
added
>enhancement
:Core/Infra/CLI
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
Collaborator
|
Hi @rjernst, I've created a changelog YAML for you. |
DaveCTurner
reviewed
Mar 14, 2025
Contributor
DaveCTurner
left a comment
DaveCTurner
left a comment
There was a problem hiding this comment.
I think we need the same in distribution/src/bin/elasticsearch-env.bat too
Member
Author
|
Doh! I had done the change to the .bat but the wrong one (a build file) 🤦 . Pushed that as well. |
Member
Author
|
@elasticmachine update branch |
rjernst
added
the
auto-backport
Member
Author
|
@elasticmachine update branch |
This was referenced Mar 15, 2025
Collaborator
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Mar 15, 2025
The JVM has a couple ways that Java options can be passed. In Elasticsearch we ignore these common patterns, instead using our own bespoke mechanisms for setting options (ES_JAVA_OPTS, etc). The primary reason for this is some systems like Ubuntu setting these options globally and then affecting Elasticsearch, often in ways that cause Elasticsearch to fail to start. This commit ignores _JAVA_OPTIONS, which is a little known environment variable that the JVM may pick up options from.
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Mar 15, 2025
The JVM has a couple ways that Java options can be passed. In Elasticsearch we ignore these common patterns, instead using our own bespoke mechanisms for setting options (ES_JAVA_OPTS, etc). The primary reason for this is some systems like Ubuntu setting these options globally and then affecting Elasticsearch, often in ways that cause Elasticsearch to fail to start. This commit ignores _JAVA_OPTIONS, which is a little known environment variable that the JVM may pick up options from.
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Mar 15, 2025
The JVM has a couple ways that Java options can be passed. In Elasticsearch we ignore these common patterns, instead using our own bespoke mechanisms for setting options (ES_JAVA_OPTS, etc). The primary reason for this is some systems like Ubuntu setting these options globally and then affecting Elasticsearch, often in ways that cause Elasticsearch to fail to start. This commit ignores _JAVA_OPTIONS, which is a little known environment variable that the JVM may pick up options from.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 15, 2025
The JVM has a couple ways that Java options can be passed. In Elasticsearch we ignore these common patterns, instead using our own bespoke mechanisms for setting options (ES_JAVA_OPTS, etc). The primary reason for this is some systems like Ubuntu setting these options globally and then affecting Elasticsearch, often in ways that cause Elasticsearch to fail to start. This commit ignores _JAVA_OPTIONS, which is a little known environment variable that the JVM may pick up options from.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 15, 2025
The JVM has a couple ways that Java options can be passed. In Elasticsearch we ignore these common patterns, instead using our own bespoke mechanisms for setting options (ES_JAVA_OPTS, etc). The primary reason for this is some systems like Ubuntu setting these options globally and then affecting Elasticsearch, often in ways that cause Elasticsearch to fail to start. This commit ignores _JAVA_OPTIONS, which is a little known environment variable that the JVM may pick up options from.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 17, 2025
The JVM has a couple ways that Java options can be passed. In Elasticsearch we ignore these common patterns, instead using our own bespoke mechanisms for setting options (ES_JAVA_OPTS, etc). The primary reason for this is some systems like Ubuntu setting these options globally and then affecting Elasticsearch, often in ways that cause Elasticsearch to fail to start. This commit ignores _JAVA_OPTIONS, which is a little known environment variable that the JVM may pick up options from. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JVM has a couple ways that Java options can be passed. In Elasticsearch we ignore these common patterns, instead using our own bespoke mechanisms for setting options (ES_JAVA_OPTS, etc). The primary reason for this is some systems like Ubuntu setting these options globally and then affecting Elasticsearch, often in ways that cause Elasticsearch to fail to start.
This commit ignores _JAVA_OPTIONS, which is a little known environment variable that the JVM may pick up options from.