Restore V8 REST compatibility around highlight force_source parameter#124873
Merged
javanna merged 2 commits intoelastic:mainfrom Mar 14, 2025
Merged
Restore V8 REST compatibility around highlight force_source parameter#124873javanna merged 2 commits intoelastic:mainfrom
javanna merged 2 commits intoelastic:mainfrom
Conversation
While that was an approved breaking change, the change should have ensured v8 compatibility, so that under v8 compatiblity mode the parameter is still accepted, but rejected in v9 compatibility mode (default). This commit ensures compatiblity and adds a test for it.
javanna
added
>bug
:Search Relevance/Highlighting
elasticsearchmachine
added
the
Team:Search Relevance
Collaborator
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
Collaborator
|
Hi @javanna, I've created a changelog YAML for you. |
javanna
added
the
auto-backport
javanna
added a commit
to javanna/elasticsearch
that referenced
this pull request
Mar 14, 2025
…elastic#124873) While that was an approved breaking change, the change should have ensured v8 compatibility, so that under v8 compatibility mode the parameter is still accepted, but rejected in v9 compatibility mode (default). This commit ensures compatibility and adds a test for it.
Collaborator
💚 Backport successful
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While that was an approved breaking change, the change should have ensured v8 compatibility, so that under v8 compatibility mode the parameter is still accepted, but rejected in v9 compatibility mode (default).
This commit ensures compatibility and adds a test for it.