[ES|QL] COMPLETION command grammar and logical plan#126319
Merged
afoucret merged 18 commits intoelastic:mainfrom Apr 11, 2025
Merged
[ES|QL] COMPLETION command grammar and logical plan#126319afoucret merged 18 commits intoelastic:mainfrom
afoucret merged 18 commits intoelastic:mainfrom
Conversation
added 7 commits
April 4, 2025 16:52
…esql-completion-logical-plan
Collaborator
|
Hi @afoucret, I've created a changelog YAML for you. |
ioanatia
reviewed
Apr 9, 2025
x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/parser/LogicalPlanBuilder.java
Outdated
Show resolved
Hide resolved
...lugin/esql/src/main/java/org/elasticsearch/xpack/esql/plan/logical/inference/Completion.java
Outdated
Show resolved
Hide resolved
...lugin/esql/src/main/java/org/elasticsearch/xpack/esql/plan/logical/inference/Completion.java
Show resolved
Hide resolved
x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/parser/LogicalPlanBuilder.java
Outdated
Show resolved
Hide resolved
elasticsearchmachine
added
the
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
…esql-completion-logical-plan
11 tasks
ioanatia
approved these changes
Apr 10, 2025
Contributor
ioanatia
left a comment
ioanatia
left a comment
There was a problem hiding this comment.
I'm okay with getting this PR in first and allow for incremental progress.
It's snapshot only so we should be good.
Looking at the current changes I don't think they will change dramatically when you end up implementing the rest of the COMPLETION command.
carlosdelest
approved these changes
Apr 10, 2025
...esql/src/test/java/org/elasticsearch/xpack/esql/parser/GrammarInDevelopmentParsingTests.java
Outdated
Show resolved
Hide resolved
…parser/GrammarInDevelopmentParsingTests.java Co-authored-by: Carlos Delgado <6339205+carlosdelest@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implement the grammar and logical plan for the
COMPLETIONcommand:prompt: expression for the prompt to be send to the LLM, requiredinferenceId: the inference id for the inference endpoint to be used, requiredtargetField: name of he output target field, optional default =completionWork for the completion command is tracked in: #124405.