Skip to content

Correctly handle nulls in nested paths in the remove processor#126417

Merged
joegallo merged 7 commits intoelastic:mainfrom
joegallo:remove-processor-null-in-path
Apr 7, 2025
Merged

Correctly handle nulls in nested paths in the remove processor#126417
joegallo merged 7 commits intoelastic:mainfrom
joegallo:remove-processor-null-in-path

Conversation

@joegallo
Copy link
Contributor

@joegallo joegallo commented Apr 7, 2025

Fixes a bug that was introduced by #125232.

During path traversal, if we find a null, then that doesn't necessarily mean we must throw an exception -- rather, we should only throw an exception on null if ignoreMissing is false.
joegallo added 3 commits April 7, 2025 11:27
@joegallo
Conserve precious characters
c134b04
@joegallo
Add failing tests
242dbe6
@joegallo
Correcly handle nulls during path traversal
4fe651c 
If we run into a null, just treat that the same as any other missing
field -- so if ignoreMissing is true, then we should not throw an
exception.
@joegallo joegallo added >bug :Distributed/Ingest Node Execution or management of Ingest Pipelines Team:Data Management (obsolete) DO NOT USE. This team no longer exists. v8.19.0 v9.1.0 labels Apr 7, 2025
@joegallo joegallo requested a review from parkertimmins April 7, 2025 15:54
@joegallo joegallo added the auto-backport Automatically create backport pull requests when merged label Apr 7, 2025
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Apr 7, 2025

Pinging @elastic/es-data-management (Team:Data Management)
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Apr 7, 2025

Hi @joegallo, I've created a changelog YAML for you.
@joegallo joegallo requested a review from parkertimmins April 7, 2025 16:38
parkertimmins
parkertimmins approved these changes Apr 7, 2025
View reviewed changes
Copy link
Contributor

@parkertimmins parkertimmins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
@joegallo joegallo merged commit bead858 into elastic:main Apr 7, 2025
17 checks passed
@joegallo joegallo deleted the remove-processor-null-in-path branch April 7, 2025 20:54
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Apr 7, 2025

💔 Backport failed

Status Branch Result
❌ 8.x Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 126417
This was referenced Apr 7, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Apr 7, 2025
Closed
Closed
Closed
Closed
Closed
@joegallo joegallo mentioned this pull request Apr 8, 2025
Merged
elasticsearchmachine pushed a commit that referenced this pull request Apr 8, 2025
@joegallo
[8.x] Correctly handle nulls in nested paths in the remove processor (#…
ec709ef 
…126463)

* Correctly handle nulls in nested paths in the remove processor (#126417)

* [CI] Auto commit changes from spotless

---------

Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co>
This was referenced Apr 8, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@kcreddy kcreddy mentioned this pull request Apr 16, 2025
Merged
5 tasks
@joegallo joegallo mentioned this pull request Apr 17, 2025
Merged
This was referenced May 7, 2025
Closed
Closed
Closed
Closed
Closed
@kcreddy kcreddy mentioned this pull request Dec 5, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged >bug :Distributed/Ingest Node Execution or management of Ingest Pipelines Team:Data Management (obsolete) DO NOT USE. This team no longer exists. v8.19.0 v9.1.0

3 participants

@joegallo @elasticsearchmachine @parkertimmins