Run newShardSnapshotTask tasks concurrently#126452
Merged
elasticsearchmachine merged 4 commits intoelastic:mainfrom Apr 8, 2025
Merged
Run newShardSnapshotTask tasks concurrently#126452elasticsearchmachine merged 4 commits intoelastic:mainfrom
newShardSnapshotTask tasks concurrently#126452elasticsearchmachine merged 4 commits intoelastic:mainfrom
Conversation
In elastic#88707 we changed the behaviour here to run the shard-snapshot initialization tasks all in sequence. Yet these tasks do nontrivial work since they may flush to acquire the relevant index commit, so with this commit we go back to distributing them across the `SNAPSHOT` pool again.
DaveCTurner
added
>bug
:Distributed/Snapshot/Restore
elasticsearchmachine
added
the
Team:Distributed Coordination (obsolete)
Collaborator
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
Collaborator
|
Hi @DaveCTurner, I've created a changelog YAML for you. |
pxsalehi
reviewed
Apr 8, 2025
Comment on lines
+435
to
+436
| // apply some backpressure by reserving one SNAPSHOT thread for the startup work | ||
| startShardSnapshotTaskRunner.runSyncTasksEagerly(threadPool.executor(ThreadPool.Names.SNAPSHOT)); |
Member
There was a problem hiding this comment.
I see this is a pattern used else where too. Adds basically one more level on top of throttled task runner which is one more level on top of threadpool. :) Was there a case where the throttled task runner was causing an issue that we had to add this extra piece to it? I'm wondering then if we're just running too many stuff in the same threadpool which lead to this.
Contributor
Author
There was a problem hiding this comment.
The unbounded queue in the ThrottledTaskRunner is always a worry, yes.
pxsalehi
approved these changes
Apr 8, 2025
Member
pxsalehi
left a comment
pxsalehi
left a comment
There was a problem hiding this comment.
One generic question for my understanding. Otherwise, LGTM.
DaveCTurner
added
the
auto-merge-without-approval
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Apr 8, 2025
In elastic#88707 we changed the behaviour here to run the shard-snapshot initialization tasks all in sequence. Yet these tasks do nontrivial work since they may flush to acquire the relevant index commit, so with this commit we go back to distributing them across the `SNAPSHOT` pool again. Backport of elastic#126452 to `8.x`
Contributor
Author
|
Backport is #126478 |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 8, 2025
In #88707 we changed the behaviour here to run the shard-snapshot initialization tasks all in sequence. Yet these tasks do nontrivial work since they may flush to acquire the relevant index commit, so with this commit we go back to distributing them across the `SNAPSHOT` pool again. Backport of #126452 to `8.x`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #88707 we changed the behaviour here to run the shard-snapshot
initialization tasks all in sequence. Yet these tasks do nontrivial work
since they may flush to acquire the relevant index commit, so with this
commit we go back to distributing them across the
SNAPSHOTpool again.