[ES|QL] COMPLETION command analysis.#126677
Merged
afoucret merged 3 commits intoelastic:mainfrom Apr 11, 2025
Merged
Conversation
elasticsearchmachine
added
the
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
11 tasks
afoucret
commented
Apr 11, 2025
| } | ||
| } | ||
|
|
||
| public void testResolveCompletionInferenceId() { |
Contributor
Author
There was a problem hiding this comment.
ℹ️ The code that does the inference resolution is from the #123074 PR.
afoucret
commented
Apr 11, 2025
| prompt = prompt.transformUp(UnresolvedAttribute.class, ua -> maybeResolveAttribute(ua, childrenOutput)); | ||
| } | ||
|
|
||
| if (prompt.resolved() && DataType.isString(prompt.dataType()) == false) { |
Contributor
Author
There was a problem hiding this comment.
ℹ️ We support only text as prompt.
ioanatia
reviewed
Apr 11, 2025
x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/analysis/Analyzer.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/analysis/AnalyzerTests.java
Outdated
Show resolved
Hide resolved
ioanatia
approved these changes
Apr 11, 2025
Contributor
ioanatia
left a comment
ioanatia
left a comment
There was a problem hiding this comment.
does what is says - looks good to me
17 tasks
afoucret
added a commit
to afoucret/elasticsearch
that referenced
this pull request
Jun 4, 2025
* [ES|QL] COMPLETION command analysis. * Moving prompt type test in postAnalysisVerification * Test lint.
afoucret
added a commit
to afoucret/elasticsearch
that referenced
this pull request
Jun 4, 2025
* [ES|QL] COMPLETION command analysis. * Moving prompt type test in postAnalysisVerification * Test lint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implement resolution of expressions for the
COMPLETIONcommand in theAnalyzer.Work for the completion command is tracked in: #124405
PS: the command is available only for snapshot build.