[ML] Adding timeout to request for creating inference endpoint#126805
Merged
jonathan-buttner merged 8 commits intoelastic:mainfrom May 6, 2025
Merged
Conversation
Collaborator
|
Hi @jonathan-buttner, I've created a changelog YAML for you. |
…rt-timeout-put-inference
…rt-timeout-put-inference
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
jonathan-buttner
added a commit
to jonathan-buttner/elasticsearch
that referenced
this pull request
May 6, 2025
…out to request (elastic#126805) * Fixing bug with listener and adding timeout * Update docs/changelog/126805.yaml * Fixing tests * Fixing writeTo (cherry picked from commit 4c507e2) # Conflicts: # server/src/main/java/org/elasticsearch/TransportVersions.java
parkertimmins
pushed a commit
to parkertimmins/elasticsearch
that referenced
this pull request
May 7, 2025
…out to request (elastic#126805) * Fixing bug with listener and adding timeout * Update docs/changelog/126805.yaml * Fixing tests * Fixing writeTo
jonathan-buttner
added a commit
that referenced
this pull request
May 8, 2025
…#126805) (#127779) * [ML] Fixing bug with TransportPutModelAction listener and adding timeout to request (#126805) * Fixing bug with listener and adding timeout * Update docs/changelog/126805.yaml * Fixing tests * Fixing writeTo (cherry picked from commit 4c507e2) # Conflicts: # server/src/main/java/org/elasticsearch/TransportVersions.java * Fixing test issue * Fixing comment length
ywangd
pushed a commit
to ywangd/elasticsearch
that referenced
this pull request
May 9, 2025
…out to request (elastic#126805) * Fixing bug with listener and adding timeout * Update docs/changelog/126805.yaml * Fixing tests * Fixing writeTo
afoucret
pushed a commit
to afoucret/elasticsearch
that referenced
this pull request
May 9, 2025
…out to request (elastic#126805) * Fixing bug with listener and adding timeout * Update docs/changelog/126805.yaml * Fixing tests * Fixing writeTo
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
May 12, 2025
…out to request (elastic#126805) * Fixing bug with listener and adding timeout * Update docs/changelog/126805.yaml * Fixing tests * Fixing writeTo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR also adds the
timeoutquery parameter to the PUT request so users can specify a longer timeout than the default 30 seconds. 30 seconds was used previously based on the ack timeout for the master node.The timeout only applies to the start deployment request and the inference request during validation. The model download request ignores the timeout because it waits for the model to finish downloading before responding on the listener.
Testing
This request should result in a failure like the following