Rare terms aggregation false **positive** fix#126884
Merged
nik9000 merged 7 commits intoelastic:mainfrom Apr 24, 2025
Merged
Conversation
elasticsearchmachine
added
v9.1.0
needs:triage
limotova
added
:Analytics/Aggregations
elasticsearchmachine
added
the
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
Contributor
Author
|
hello there, it's about a week since this pr was created, can anyone review this please? |
nik9000
approved these changes
Apr 24, 2025
Member
nik9000
left a comment
nik9000
left a comment
There was a problem hiding this comment.
Looks good. I'm going to make the robot happy and get this in.
nik9000
added
auto-backport
Member
|
Changelogbot, I've pushed a changelog. |
Member
|
@iamgd67, what version are you using? |
Member
|
Sorry for the long delay. Busy looking at very different areas, but yeah. Well done. Thanks for waiting! |
Member
|
elasticmachine, test this please |
Member
|
elasticmachine test this please |
Member
|
buildkite run elasticsearch-ci |
Member
|
buildkite test this |
Member
|
buildkite test this |
This was referenced Apr 24, 2025
nik9000
pushed a commit
to nik9000/elasticsearch
that referenced
this pull request
Apr 24, 2025
I found that `rare_terms` aggregation can return **false positive**
results (some of the returned results are not real). I traced it
down and find out it's a bug in `CuckooFilter`'s merge methord.
```
if (isSetMode == false && other.isSetMode) {
other.hashes.forEach(this::add);
}
```
should be
```
if (isSetMode == false && other.isSetMode) {
other.hashes.forEach(this::addHash);
}
```
Collaborator
nik9000
pushed a commit
to nik9000/elasticsearch
that referenced
this pull request
Apr 24, 2025
I found that `rare_terms` aggregation can return **false positive**
results (some of the returned results are not real). I traced it
down and find out it's a bug in `CuckooFilter`'s merge methord.
```
if (isSetMode == false && other.isSetMode) {
other.hashes.forEach(this::add);
}
```
should be
```
if (isSetMode == false && other.isSetMode) {
other.hashes.forEach(this::addHash);
}
```
nik9000
pushed a commit
to nik9000/elasticsearch
that referenced
this pull request
Apr 24, 2025
I found that `rare_terms` aggregation can return **false positive**
results (some of the returned results are not real). I traced it
down and find out it's a bug in `CuckooFilter`'s merge methord.
```
if (isSetMode == false && other.isSetMode) {
other.hashes.forEach(this::add);
}
```
should be
```
if (isSetMode == false && other.isSetMode) {
other.hashes.forEach(this::addHash);
}
```
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 24, 2025
I found that `rare_terms` aggregation can return **false positive**
results (some of the returned results are not real). I traced it
down and find out it's a bug in `CuckooFilter`'s merge methord.
```
if (isSetMode == false && other.isSetMode) {
other.hashes.forEach(this::add);
}
```
should be
```
if (isSetMode == false && other.isSetMode) {
other.hashes.forEach(this::addHash);
}
```
Co-authored-by: iamgd67 <iamgd67@sina.com>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 24, 2025
I found that `rare_terms` aggregation can return **false positive**
results (some of the returned results are not real). I traced it
down and find out it's a bug in `CuckooFilter`'s merge methord.
```
if (isSetMode == false && other.isSetMode) {
other.hashes.forEach(this::add);
}
```
should be
```
if (isSetMode == false && other.isSetMode) {
other.hashes.forEach(this::addHash);
}
```
Co-authored-by: iamgd67 <iamgd67@sina.com>
Contributor
Author
thanks for your review and merge. I am using 7.17.8 |
nik9000
added a commit
that referenced
this pull request
Apr 25, 2025
I found that `rare_terms` aggregation can return **false positive**
results (some of the returned results are not real). I traced it
down and find out it's a bug in `CuckooFilter`'s merge methord.
```
if (isSetMode == false && other.isSetMode) {
other.hashes.forEach(this::add);
}
```
should be
```
if (isSetMode == false && other.isSetMode) {
other.hashes.forEach(this::addHash);
}
```
Co-authored-by: iamgd67 <iamgd67@sina.com>
Member
Oof. The earliest version I can get this to is 8.17. I've already got it back to 8.18 but would have to manaully pull it one more back if you want it there. Sorry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that
rare terms aggregationcan return false positive results (some of the returned results are not real rear).I traced it down and find out it's a bug in
CuckooFilter's merge methord.should be