Improve Netty4IncrementalRequestHandlingIT#127111
Merged
elasticsearchmachine merged 4 commits intoelastic:mainfrom Apr 22, 2025
Merged
Conversation
* Verifies that each call to `Netty4HttpRequestBodyStream#next` yields exactly one chunk (or the stream is closed) since the `IncrementalBulkService` relies on this property. * Replaces several busy-waits with ones that block on a future for faster test execution. * Replaces several hard-coded constants with randomized values to clarify that the precise value does not matter to the test. * Reduces the use of unnecessary abbreviations in names. * Reduce the use of global static state in favour of node-local components.
DaveCTurner
added
>test
DaveCTurner
requested review from
DiannaHohensee,
JeremyDahlgren,
mhl-b and
nicktindall
elasticsearchmachine
added
the
Team:Distributed Coordination (obsolete)
Collaborator
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
…ing-chunk-at-once
nicktindall
approved these changes
Apr 22, 2025
| } | ||
| } | ||
|
|
||
| // ensures content integrity, no loses and re-order |
…ing-chunk-at-once
DaveCTurner
added
the
auto-merge-without-approval
DaveCTurner
deleted the
2025/04/20/netty-incremental-request-processing-chunk-at-once
branch
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Apr 23, 2025
Re-applying elastic#126441 with the extra `FlowControlHandler` needed to ensure one-chunk-per-read semantics - see elastic#127111 for related tests.
DaveCTurner
added a commit
that referenced
this pull request
Apr 25, 2025
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
May 7, 2025
Re-applying elastic#126441 (cf. elastic#127259) with: - the extra `FlowControlHandler` needed to ensure one-chunk-per-read semantics (also present in elastic#127259). - no extra `read()` after exhausting a `Netty4HttpRequestBodyStream` (the bug behind elastic#127391 and elastic#127391). See elastic#127111 for related tests.
ywangd
pushed a commit
to ywangd/elasticsearch
that referenced
this pull request
May 9, 2025
…127817) Re-applying elastic#126441 (cf. elastic#127259) with: - the extra `FlowControlHandler` needed to ensure one-chunk-per-read semantics (also present in elastic#127259). - no extra `read()` after exhausting a `Netty4HttpRequestBodyStream` (the bug behind elastic#127391 and elastic#127391). See elastic#127111 for related tests.
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
May 12, 2025
…127817) Re-applying elastic#126441 (cf. elastic#127259) with: - the extra `FlowControlHandler` needed to ensure one-chunk-per-read semantics (also present in elastic#127259). - no extra `read()` after exhausting a `Netty4HttpRequestBodyStream` (the bug behind elastic#127391 and elastic#127391). See elastic#127111 for related tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verifies that each call to
Netty4HttpRequestBodyStream#nextyieldsexactly one chunk (or the stream is closed) since the
IncrementalBulkServicerelies on this property.Replaces several busy-waits with ones that block on a future for
faster test execution.
Replaces several hard-coded constants with randomized values to
clarify that the precise value does not matter to the test.
Reduces the use of unnecessary abbreviations in names.
Reduce the use of global static state in favour of node-local
components.