Emit ordinal output block for values aggregate#127201
Merged
dnhatn merged 3 commits intoelastic:mainfrom Apr 23, 2025
Merged
Conversation
9a07845 to
84b187f
Compare
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
Collaborator
|
Hi @dnhatn, I've created a changelog YAML for you. |
kkrik-es
approved these changes
Apr 23, 2025
Member
Author
|
Thanks Kostas! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Time-series aggregations rely heavily on the
valuesaggregation for collecting grouping values. For example:is translated to:
We might change how these are executed later, but for now, we need to optimize the
valuesaggregation forBytesRef, especially in cases with low cardinality. This change emits ordinal blocks as the output of thevaluesaggregation, allowing the second aggregation to execute more efficiently. I will also open a PR to handle incoming ordinal blocks for thevaluesaggregation.