Always log data node failures#127420
Merged
benchaplin merged 6 commits intoelastic:mainfrom Apr 29, 2025
Merged
Conversation
elasticsearchmachine
added
needs:triage
benchaplin
added
>bug
Team:Search Foundations
Collaborator
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
benchaplin
added
v8.18.1
v8.19.0
v9.0.1
v9.1.0
auto-backport
Collaborator
|
Hi @benchaplin, I've created a changelog YAML for you. |
benchaplin
force-pushed
the
always_log_data_node_failures
branch
from
b54f67a to
7f21c17
Compare
Contributor
Author
|
@elasticsearchmachine run elasticsearch-ci/part-1 |
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
benchaplin
added a commit
to benchaplin/elasticsearch
that referenced
this pull request
Apr 29, 2025
Log search exceptions as they occur on the data node no matter the value of error_trace. (cherry picked from commit 0538958) # Conflicts: # qa/smoke-test-http/src/internalClusterTest/java/org/elasticsearch/http/SearchErrorTraceIT.java # server/src/main/java/org/elasticsearch/search/SearchService.java # server/src/test/java/org/elasticsearch/search/SearchServiceTests.java # x-pack/plugin/async-search/src/internalClusterTest/java/org/elasticsearch/xpack/search/AsyncSearchErrorTraceIT.java
benchaplin
added a commit
to benchaplin/elasticsearch
that referenced
this pull request
Apr 29, 2025
Log search exceptions as they occur on the data node no matter the value of error_trace. (cherry picked from commit 0538958) # Conflicts: # server/src/main/java/org/elasticsearch/search/SearchService.java # server/src/test/java/org/elasticsearch/search/SearchServiceTests.java
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
benchaplin
added a commit
to benchaplin/elasticsearch
that referenced
this pull request
Apr 29, 2025
Log search exceptions as they occur on the data node no matter the value of error_trace. (cherry picked from commit 0538958) # Conflicts: # qa/smoke-test-http/src/internalClusterTest/java/org/elasticsearch/http/SearchErrorTraceIT.java # server/src/main/java/org/elasticsearch/search/SearchService.java # server/src/test/java/org/elasticsearch/search/SearchServiceTests.java # x-pack/plugin/async-search/src/internalClusterTest/java/org/elasticsearch/xpack/search/AsyncSearchErrorTraceIT.java
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 29, 2025
Log search exceptions as they occur on the data node no matter the value of error_trace. (cherry picked from commit 0538958) # Conflicts: # qa/smoke-test-http/src/internalClusterTest/java/org/elasticsearch/http/SearchErrorTraceIT.java # server/src/main/java/org/elasticsearch/search/SearchService.java # server/src/test/java/org/elasticsearch/search/SearchServiceTests.java # x-pack/plugin/async-search/src/internalClusterTest/java/org/elasticsearch/xpack/search/AsyncSearchErrorTraceIT.java
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 29, 2025
Log search exceptions as they occur on the data node no matter the value of error_trace. (cherry picked from commit 0538958) # Conflicts: # server/src/main/java/org/elasticsearch/search/SearchService.java # server/src/test/java/org/elasticsearch/search/SearchServiceTests.java
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 29, 2025
Log search exceptions as they occur on the data node no matter the value of error_trace. (cherry picked from commit 0538958) # Conflicts: # qa/smoke-test-http/src/internalClusterTest/java/org/elasticsearch/http/SearchErrorTraceIT.java # server/src/main/java/org/elasticsearch/search/SearchService.java # server/src/test/java/org/elasticsearch/search/SearchServiceTests.java # x-pack/plugin/async-search/src/internalClusterTest/java/org/elasticsearch/xpack/search/AsyncSearchErrorTraceIT.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjust error listener:
From:
error_trace = false, log exception then clear stack trace.To:
Always log exception.
error_trace = false, clear stack trace.When working on #125732, I thought it'd be OK to skip logging the exception when
error_trace = truebecause the stack trace would be sent to the coordinating node and logged in the REST suppressed logger. However, the REST suppressed logger logs nothing if there are partial results. That means there's no exception logged whenerror_trace = trueand another shard succeeds. However, we're still interested in these errors and should log and alert on them.