Remove dangling spaces wherever found. by ankit--sethi · Pull Request #127475 · elastic/elasticsearch

ankit--sethi · 2025-04-28T16:35:34Z

This PR addresses #117067 , a report about unexpected spaces breaking message parsers built by customers.

I used the regex (\. \")(?![A-Z(a-z_0-9-;<%\/\.+ \t\n]+) to detect such instances and clean up. In one case, a minor code improvement helps add optional spaces as necessary for a multi-sentence error message.

This PR addresses elastic#117067 , a report about unexpected spaces breaking message parsers built by customers. I used the regex `(\. \")(?![A-Z(a-z_0-9-;<%\/\.+ \t\n]+)` to detect such instances and clean up. In one case, a minor code improvement helps add optional spaces as necessary for a multi-sentence error message.

…ature/dangling-spaces

elasticsearchmachine · 2025-04-28T18:58:40Z

Pinging @elastic/es-security (Team:Security)

elasticsearchmachine · 2025-04-28T18:59:31Z

Hi @ankit--sethi, I've created a changelog YAML for you.

…ature/dangling-spaces

slobodanadamovic

LGTM 👍

parkertimmins · 2025-04-30T16:25:33Z

...orm/src/main/java/org/elasticsearch/xpack/transform/action/TransportStopTransformAction.java

                    StringBuilder message = new StringBuilder();
+                    boolean lineAdded = false;
                    if (persistentTaskIds.size() - stillRunningTasks.size() - exceptions.size() > 0) {
+                        message.append(optionalSpace(lineAdded));


nit: might be a bit cleaner to use message.length() > 0 instead of adding the variable lineAdded

good point, I'm a little antsy about upsetting the CI build with another commit but I'll keep in mind for next time!

elasticsearchmachine · 2025-04-30T18:06:33Z

Hi @ankit--sethi, I've updated the changelog YAML for you.

elasticsearchmachine · 2025-05-01T15:35:32Z

💔 Backport failed

Status	Branch	Result
❌	8.19	Commit could not be cherrypicked due to conflicts
❌	8.17	Commit could not be cherrypicked due to conflicts
❌	8.18	Commit could not be cherrypicked due to conflicts
❌	9.0	Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 127475

* Remove dandling spaces wherever found. This PR addresses elastic#117067 , a report about unexpected spaces breaking message parsers built by customers. I used the regex `(\. \")(?![A-Z(a-z_0-9-;<%\/\.+ \t\n]+)` to detect such instances and clean up. In one case, a minor code improvement helps add optional spaces as necessary for a multi-sentence error message. * fix test * Update docs/changelog/127475.yaml * correct logic * fix test * fix tests * fix tests * fix tests * Update docs/changelog/127475.yaml * Update x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/action/TransportGetInferenceModelAction.java Co-authored-by: Slobodan Adamović <slobodanadamovic@users.noreply.github.com> * Update libs/x-content/src/main/java/org/elasticsearch/xcontent/ObjectParser.java Co-authored-by: Slobodan Adamović <slobodanadamovic@users.noreply.github.com> * correctly reference issue * Update docs/changelog/127475.yaml --------- Co-authored-by: Slobodan Adamović <slobodanadamovic@users.noreply.github.com> (cherry picked from commit 94854b3)

* Remove dandling spaces wherever found. This PR addresses #117067 , a report about unexpected spaces breaking message parsers built by customers. I used the regex `(\. \")(?![A-Z(a-z_0-9-;<%\/\.+ \t\n]+)` to detect such instances and clean up. In one case, a minor code improvement helps add optional spaces as necessary for a multi-sentence error message. * fix test * Update docs/changelog/127475.yaml * correct logic * fix test * fix tests * fix tests * fix tests * Update docs/changelog/127475.yaml * Update x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/action/TransportGetInferenceModelAction.java Co-authored-by: Slobodan Adamović <slobodanadamovic@users.noreply.github.com> * Update libs/x-content/src/main/java/org/elasticsearch/xcontent/ObjectParser.java Co-authored-by: Slobodan Adamović <slobodanadamovic@users.noreply.github.com> * correctly reference issue * Update docs/changelog/127475.yaml --------- Co-authored-by: Slobodan Adamović <slobodanadamovic@users.noreply.github.com> (cherry picked from commit 94854b3)

* Remove dandling spaces wherever found. This PR addresses elastic#117067 , a report about unexpected spaces breaking message parsers built by customers. I used the regex `(\. \")(?![A-Z(a-z_0-9-;<%\/\.+ \t\n]+)` to detect such instances and clean up. In one case, a minor code improvement helps add optional spaces as necessary for a multi-sentence error message. * fix test * Update docs/changelog/127475.yaml * correct logic * fix test * fix tests * fix tests * fix tests * Update docs/changelog/127475.yaml * Update x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/action/TransportGetInferenceModelAction.java Co-authored-by: Slobodan Adamović <slobodanadamovic@users.noreply.github.com> * Update libs/x-content/src/main/java/org/elasticsearch/xcontent/ObjectParser.java Co-authored-by: Slobodan Adamović <slobodanadamovic@users.noreply.github.com> * correctly reference issue * Update docs/changelog/127475.yaml --------- Co-authored-by: Slobodan Adamović <slobodanadamovic@users.noreply.github.com> (cherry picked from commit 94854b3)

* Remove dandling spaces wherever found. This PR addresses #117067 , a report about unexpected spaces breaking message parsers built by customers. I used the regex `(\. \")(?![A-Z(a-z_0-9-;<%\/\.+ \t\n]+)` to detect such instances and clean up. In one case, a minor code improvement helps add optional spaces as necessary for a multi-sentence error message. * fix test * Update docs/changelog/127475.yaml * correct logic * fix test * fix tests * fix tests * fix tests * Update docs/changelog/127475.yaml * Update x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/action/TransportGetInferenceModelAction.java Co-authored-by: Slobodan Adamović <slobodanadamovic@users.noreply.github.com> * Update libs/x-content/src/main/java/org/elasticsearch/xcontent/ObjectParser.java Co-authored-by: Slobodan Adamović <slobodanadamovic@users.noreply.github.com> * correctly reference issue * Update docs/changelog/127475.yaml --------- Co-authored-by: Slobodan Adamović <slobodanadamovic@users.noreply.github.com> (cherry picked from commit 94854b3)

* Remove dandling spaces wherever found. This PR addresses elastic#117067 , a report about unexpected spaces breaking message parsers built by customers. I used the regex `(\. \")(?![A-Z(a-z_0-9-;<%\/\.+ \t\n]+)` to detect such instances and clean up. In one case, a minor code improvement helps add optional spaces as necessary for a multi-sentence error message. * fix test * Update docs/changelog/127475.yaml * correct logic * fix test * fix tests * fix tests * fix tests * Update docs/changelog/127475.yaml * Update x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/action/TransportGetInferenceModelAction.java Co-authored-by: Slobodan Adamović <slobodanadamovic@users.noreply.github.com> * Update libs/x-content/src/main/java/org/elasticsearch/xcontent/ObjectParser.java Co-authored-by: Slobodan Adamović <slobodanadamovic@users.noreply.github.com> * correctly reference issue * Update docs/changelog/127475.yaml --------- Co-authored-by: Slobodan Adamović <slobodanadamovic@users.noreply.github.com> (cherry picked from commit 94854b3)

* Remove dandling spaces wherever found. This PR addresses #117067 , a report about unexpected spaces breaking message parsers built by customers. I used the regex `(\. \")(?![A-Z(a-z_0-9-;<%\/\.+ \t\n]+)` to detect such instances and clean up. In one case, a minor code improvement helps add optional spaces as necessary for a multi-sentence error message. * fix test * Update docs/changelog/127475.yaml * correct logic * fix test * fix tests * fix tests * fix tests * Update docs/changelog/127475.yaml * Update x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/action/TransportGetInferenceModelAction.java Co-authored-by: Slobodan Adamović <slobodanadamovic@users.noreply.github.com> * Update libs/x-content/src/main/java/org/elasticsearch/xcontent/ObjectParser.java Co-authored-by: Slobodan Adamović <slobodanadamovic@users.noreply.github.com> * correctly reference issue * Update docs/changelog/127475.yaml --------- Co-authored-by: Slobodan Adamović <slobodanadamovic@users.noreply.github.com> (cherry picked from commit 94854b3)

ankit--sethi requested review from a team as code owners April 28, 2025 16:35

elasticsearchmachine added v9.1.0 needs:triage Requires assignment of a team area label labels Apr 28, 2025

Merge branch 'main' into feature/dangling-spaces

ae3e37c

ankit--sethi added Team:Security Meta label for security team >bug labels Apr 28, 2025

elasticsearchmachine removed the Team:Security Meta label for security team label Apr 28, 2025

ankit--sethi and others added 3 commits April 28, 2025 11:53

fix test

00e3648

Merge remote-tracking branch 'origin/feature/dangling-spaces' into fe…

68f3a76

…ature/dangling-spaces

Merge branch 'main' into feature/dangling-spaces

0a8b60a

ankit--sethi added >enhancement :Security/Security Security issues without another label and removed >bug labels Apr 28, 2025

elasticsearchmachine added the Team:Security Meta label for security team label Apr 28, 2025

elasticsearchmachine removed the needs:triage Requires assignment of a team area label label Apr 28, 2025

Update docs/changelog/127475.yaml

3efaab8

ankit--sethi and others added 7 commits April 28, 2025 14:04

correct logic

a25baf5

Merge remote-tracking branch 'origin/feature/dangling-spaces' into fe…

4eac86e

…ature/dangling-spaces

fix test

437a51f

fix tests

5a5a2ad

fix tests

f9abea4

fix tests

194cf15

Merge branch 'main' into feature/dangling-spaces

5ca5723

slobodanadamovic requested review from slobodanadamovic and removed request for a team April 29, 2025 06:10

Merge branch 'main' into feature/dangling-spaces

5276022

slobodanadamovic approved these changes Apr 30, 2025

View reviewed changes

ankit--sethi added 2 commits April 30, 2025 10:22

Merge branch 'main' into feature/dangling-spaces

45f50e2

Merge branch 'main' into feature/dangling-spaces

043f6bb

parkertimmins approved these changes Apr 30, 2025

View reviewed changes

elasticsearchmachine added v9.0.2 and removed v9.0.1 labels Apr 30, 2025

Update docs/changelog/127475.yaml

4778c87

elasticsearchmachine added v8.18.2 v8.17.7 and removed v8.18.1 v8.17.6 labels Apr 30, 2025

Merge branch 'main' into feature/dangling-spaces

91dbc86

ankit--sethi merged commit 94854b3 into elastic:main May 1, 2025
22 checks passed

elasticsearchmachine added the backport pending label May 1, 2025

ankit--sethi mentioned this pull request May 1, 2025

Remove dangling spaces wherever found. (#127475) #127607

Merged

ankit--sethi mentioned this pull request May 1, 2025

Remove dangling spaces wherever found. (#127475) #127608

Merged

ankit--sethi deleted the feature/dangling-spaces branch May 1, 2025 17:54

ankit--sethi mentioned this pull request May 1, 2025

Remove dangling spaces wherever found. (#127475) #127611

Merged

ankit--sethi mentioned this pull request May 1, 2025

Remove dangling spaces wherever found. (#127475) #127612

Merged

ankit--sethi removed the backport pending label May 1, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove dangling spaces wherever found.#127475

Remove dangling spaces wherever found.#127475
ankit--sethi merged 29 commits intoelastic:mainfrom
ankit--sethi:feature/dangling-spaces

ankit--sethi commented Apr 28, 2025

elasticsearchmachine commented Apr 28, 2025

elasticsearchmachine commented Apr 28, 2025

slobodanadamovic left a comment

parkertimmins Apr 30, 2025

ankit--sethi May 1, 2025

elasticsearchmachine commented Apr 30, 2025

Uh oh!

elasticsearchmachine commented May 1, 2025

Labels

4 participants

Conversation

ankit--sethi commented Apr 28, 2025

elasticsearchmachine commented Apr 28, 2025

elasticsearchmachine commented Apr 28, 2025

slobodanadamovic left a comment

Choose a reason for hiding this comment

parkertimmins Apr 30, 2025

Choose a reason for hiding this comment

ankit--sethi May 1, 2025

Choose a reason for hiding this comment

elasticsearchmachine commented Apr 30, 2025

Uh oh!

elasticsearchmachine commented May 1, 2025

💔 Backport failed

Labels

4 participants