Skip to content

ESQL: Improve error message for ( and [ (#124177)#127620

Merged
nik9000 merged 1 commit intoelastic:8.19from
nik9000:124177_8_19
May 1, 2025
Merged

ESQL: Improve error message for ( and [ (#124177)#127620
nik9000 merged 1 commit intoelastic:8.19from
nik9000:124177_8_19

Conversation

@nik9000
Copy link
Member

@nik9000 nik9000 commented May 1, 2025

Due to recent grammar changes made ( token to no longer be reported by its text rather by his internal token name. Due to the use of pushMode, the symbol is not treated as a literal rather as a symbol. To address this, the parser listener looks at the error message and changes the message before returning it to the user.

Fix #124145
Relates #123085 #121948

Due to recent grammar changes made ( token to no longer be reported by
its text rather by his internal token name. Due to the use of pushMode,
the symbol is not treated as a literal rather as a symbol.
To address this, the parser listener looks at the error message and
changes the message before returning it to the user.

Fix elastic#124145
Relates elastic#123085 elastic#121948
Copy link
Member

@costin costin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nik9000 nik9000 enabled auto-merge (squash) May 1, 2025 20:22
@nik9000 nik9000 merged commit 56e19e2 into elastic:8.19 May 1, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants