Skip the validation when retrieving the index mode during reindexing a time series data stream.#127824
Merged
gmarouli merged 7 commits intoelastic:mainfrom May 8, 2025
Merged
Conversation
gmarouli
added
>bug
:StorageEngine/Data streams
elasticsearchmachine
added
Team:Data Management (obsolete)
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
Collaborator
|
Hi @gmarouli, I've created a changelog YAML for you. |
martijnvg
approved these changes
May 7, 2025
Member
martijnvg
left a comment
martijnvg
left a comment
There was a problem hiding this comment.
👍
I think this bug fix should also be back ported to the 8.19 branch.
gmarouli
added
auto-backport
Contributor
Author
You are right, I will add the other active versions as well. |
Collaborator
|
Hi @gmarouli, I've updated the changelog YAML for you. |
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
gmarouli
added a commit
to gmarouli/elasticsearch
that referenced
this pull request
May 8, 2025
…a time series data stream. (elastic#127824) During reindexing we retrieve the index mode from the template settings. However, we do not fully resolve the settings as we do when validating a template or when creating a data stream. This results on throwing the error reported in elastic#125607. I do not see a reason to not fix this as suggested in elastic#125607 (comment). Fixes: elastic#125607 (cherry picked from commit 077b6b9) # Conflicts: # modules/data-streams/build.gradle # modules/reindex/src/main/java/org/elasticsearch/reindex/Reindexer.java
gmarouli
added a commit
to gmarouli/elasticsearch
that referenced
this pull request
May 8, 2025
…a time series data stream. (elastic#127824) During reindexing we retrieve the index mode from the template settings. However, we do not fully resolve the settings as we do when validating a template or when creating a data stream. This results on throwing the error reported in elastic#125607. I do not see a reason to not fix this as suggested in elastic#125607 (comment). Fixes: elastic#125607 (cherry picked from commit 077b6b9) # Conflicts: # modules/data-streams/build.gradle # modules/reindex/src/main/java/org/elasticsearch/reindex/Reindexer.java
gmarouli
added a commit
to gmarouli/elasticsearch
that referenced
this pull request
May 8, 2025
…a time series data stream. (elastic#127824) During reindexing we retrieve the index mode from the template settings. However, we do not fully resolve the settings as we do when validating a template or when creating a data stream. This results on throwing the error reported in elastic#125607. I do not see a reason to not fix this as suggested in elastic#125607 (comment). Fixes: elastic#125607 (cherry picked from commit 077b6b9) # Conflicts: # modules/data-streams/build.gradle # modules/reindex/src/main/java/org/elasticsearch/reindex/Reindexer.java
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
gmarouli
added a commit
to gmarouli/elasticsearch
that referenced
this pull request
May 8, 2025
…a time series data stream. (elastic#127824) During reindexing we retrieve the index mode from the template settings. However, we do not fully resolve the settings as we do when validating a template or when creating a data stream. This results on throwing the error reported in elastic#125607. I do not see a reason to not fix this as suggested in elastic#125607 (comment). Fixes: elastic#125607 (cherry picked from commit 077b6b9) # Conflicts: # modules/data-streams/build.gradle # modules/reindex/src/main/java/org/elasticsearch/reindex/Reindexer.java
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 8, 2025
…a time series data stream. (#127824) (#127894) During reindexing we retrieve the index mode from the template settings. However, we do not fully resolve the settings as we do when validating a template or when creating a data stream. This results on throwing the error reported in #125607. I do not see a reason to not fix this as suggested in #125607 (comment). Fixes: #125607 (cherry picked from commit 077b6b9) # Conflicts: # modules/data-streams/build.gradle # modules/reindex/src/main/java/org/elasticsearch/reindex/Reindexer.java
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 8, 2025
…a time series data stream. (#127824) (#127898) During reindexing we retrieve the index mode from the template settings. However, we do not fully resolve the settings as we do when validating a template or when creating a data stream. This results on throwing the error reported in #125607. I do not see a reason to not fix this as suggested in #125607 (comment). Fixes: #125607 (cherry picked from commit 077b6b9) # Conflicts: # modules/data-streams/build.gradle # modules/reindex/src/main/java/org/elasticsearch/reindex/Reindexer.java
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 8, 2025
…a time series data stream. (#127824) (#127900) During reindexing we retrieve the index mode from the template settings. However, we do not fully resolve the settings as we do when validating a template or when creating a data stream. This results on throwing the error reported in #125607. I do not see a reason to not fix this as suggested in #125607 (comment). Fixes: #125607 (cherry picked from commit 077b6b9) # Conflicts: # modules/data-streams/build.gradle # modules/reindex/src/main/java/org/elasticsearch/reindex/Reindexer.java
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 8, 2025
…a time series data stream. (#127824) (#127901) During reindexing we retrieve the index mode from the template settings. However, we do not fully resolve the settings as we do when validating a template or when creating a data stream. This results on throwing the error reported in #125607. I do not see a reason to not fix this as suggested in #125607 (comment). Fixes: #125607 (cherry picked from commit 077b6b9) # Conflicts: # modules/data-streams/build.gradle # modules/reindex/src/main/java/org/elasticsearch/reindex/Reindexer.java
ywangd
pushed a commit
to ywangd/elasticsearch
that referenced
this pull request
May 9, 2025
…a time series data stream. (elastic#127824) During reindexing we retrieve the index mode from the template settings. However, we do not fully resolve the settings as we do when validating a template or when creating a data stream. This results on throwing the error reported in elastic#125607. I do not see a reason to not fix this as suggested in elastic#125607 (comment). Fixes: elastic#125607
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
May 12, 2025
…a time series data stream. (elastic#127824) During reindexing we retrieve the index mode from the template settings. However, we do not fully resolve the settings as we do when validating a template or when creating a data stream. This results on throwing the error reported in elastic#125607. I do not see a reason to not fix this as suggested in elastic#125607 (comment). Fixes: elastic#125607
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During reindexing we retrieve the index mode from the template settings. However, we do not fully resolve the settings as we do when validating a template or when creating a data stream. This results on throwing the error reported in #125607.
I do not see a reason to not fix this as suggested in #125607 (comment).
Fixes: #125607