Add missing entitlement to repository-azure#128047
Merged
DaveCTurner merged 3 commits intoelastic:mainfrom May 14, 2025
Merged
Conversation
This entitlement is required, but only if validating the metadata endpoint against `https://login.microsoft.com/` which isn't something we can do in a test. Kind of a SDK bug, we should be using an existing event loop rather than spawning threads randomly like this.
DaveCTurner
added
>bug
:Distributed/Snapshot/Restore
Collaborator
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
elasticsearchmachine
added
the
Team:Distributed Coordination (obsolete)
Collaborator
|
Hi @DaveCTurner, I've created a changelog YAML for you. |
Collaborator
|
Hi @DaveCTurner, I've updated the changelog YAML for you. |
DaveCTurner
added
auto-merge-without-approval
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
May 14, 2025
This entitlement is required, but only if validating the metadata endpoint against `https://login.microsoft.com/` which isn't something we can do in a test. Kind of a SDK bug, we should be using an existing event loop rather than spawning threads randomly like this.
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
May 14, 2025
This entitlement is required, but only if validating the metadata endpoint against `https://login.microsoft.com/` which isn't something we can do in a test. Kind of a SDK bug, we should be using an existing event loop rather than spawning threads randomly like this.
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
May 14, 2025
This entitlement is required, but only if validating the metadata endpoint against `https://login.microsoft.com/` which isn't something we can do in a test. Kind of a SDK bug, we should be using an existing event loop rather than spawning threads randomly like this.
Collaborator
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 14, 2025
This entitlement is required, but only if validating the metadata endpoint against `https://login.microsoft.com/` which isn't something we can do in a test. Kind of a SDK bug, we should be using an existing event loop rather than spawning threads randomly like this.
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 14, 2025
This entitlement is required, but only if validating the metadata endpoint against `https://login.microsoft.com/` which isn't something we can do in a test. Kind of a SDK bug, we should be using an existing event loop rather than spawning threads randomly like this.
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 14, 2025
This entitlement is required, but only if validating the metadata endpoint against `https://login.microsoft.com/` which isn't something we can do in a test. Kind of a SDK bug, we should be using an existing event loop rather than spawning threads randomly like this.
richard-dennehy
pushed a commit
to richard-dennehy/elasticsearch
that referenced
this pull request
May 19, 2025
This entitlement is required, but only if validating the metadata endpoint against `https://login.microsoft.com/` which isn't something we can do in a test. Kind of a SDK bug, we should be using an existing event loop rather than spawning threads randomly like this.
benchaplin
pushed a commit
to benchaplin/elasticsearch
that referenced
this pull request
May 20, 2025
This entitlement is required, but only if validating the metadata endpoint against `https://login.microsoft.com/` which isn't something we can do in a test. Kind of a SDK bug, we should be using an existing event loop rather than spawning threads randomly like this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This entitlement is required, but only if validating the metadata
endpoint against
https://login.microsoft.com/which isn't something wecan do in a test. Kind of a SDK bug, we should be using an existing
event loop rather than spawning threads randomly like this.
Closes #128046