Skip to content

ES|QL: Make skip_unavailable catch all errors#128163

Merged
smalyshev merged 21 commits intoelastic:mainfrom
smalyshev:skip-un-ftw
May 27, 2025
Merged

ES|QL: Make skip_unavailable catch all errors#128163
smalyshev merged 21 commits intoelastic:mainfrom
smalyshev:skip-un-ftw

Conversation

@smalyshev
Copy link
Contributor

@smalyshev smalyshev commented May 19, 2025

This is a reversal of the decision in #120236, now skip_unavailable is again catching all errors, like _search.
@smalyshev smalyshev added v8.19.0 >enhancement auto-backport Automatically create backport pull requests when merged :Search Foundations/CCS labels May 21, 2025
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented May 21, 2025

Hi @smalyshev, I've created a changelog YAML for you.
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented May 21, 2025

Hi @smalyshev, I've updated the changelog YAML for you. Note that since this PR is labelled >breaking, you need to update the changelog YAML to fill out the extended information sections.
@smalyshev smalyshev marked this pull request as ready for review May 22, 2025 23:16
@smalyshev smalyshev added the :Analytics/ES|QL AKA ESQL label May 22, 2025
@smalyshev smalyshev requested review from dnhatn and quux00 May 22, 2025 23:16
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented May 22, 2025

Pinging @elastic/es-analytical-engine (Team:Analytics)
@elasticsearchmachine elasticsearchmachine added Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch labels May 22, 2025
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented May 22, 2025

Pinging @elastic/es-search-foundations (Team:Search Foundations)
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented May 22, 2025

Hi @smalyshev, I've updated the changelog YAML for you. Note that since this PR is labelled >breaking, you need to update the changelog YAML to fill out the extended information sections.
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented May 23, 2025

Hi @smalyshev, I've updated the changelog YAML for you. Note that since this PR is labelled >breaking, you need to update the changelog YAML to fill out the extended information sections.
@smalyshev smalyshev changed the title Make skip_unavailable catch all errors May 24, 2025
dnhatn
dnhatn approved these changes May 27, 2025
View reviewed changes
Copy link
Member

@dnhatn dnhatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks Stas!
@smalyshev smalyshev merged commit 8484b71 into elastic:main May 27, 2025
18 checks passed
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented May 27, 2025

💔 Backport failed

Status Branch Result
❌ 8.19 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 128163
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented May 27, 2025

@smalyshev according to this PR's labels, I need to update the changelog YAML, but I can't because the PR is closed. Please either update the changelog yourself on the appropriate branch, or adjust the labels. Specifically:

  • The PR is not labelled >breaking-java but the changelog has a breaking section
@smalyshev
Copy link
Contributor Author

smalyshev commented May 27, 2025

💚 All backports created successfully

Status Branch Result
✅ 8.19

Questions ?

Please refer to the Backport tool documentation
@smalyshev smalyshev mentioned this pull request May 27, 2025
Merged
smalyshev added a commit to smalyshev/elasticsearch that referenced this pull request May 27, 2025
@smalyshev
ES|QL: Make skip_unavailable catch all errors (elastic#128163)
96d0d6c 
* Make skip_unavailable catch all errors

(cherry picked from commit 8484b71)

# Conflicts:
#	x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/plugin/ClusterComputeHandler.java
elasticsearchmachine pushed a commit that referenced this pull request May 28, 2025
@smalyshev
[8.19] ES|QL: Make skip_unavailable catch all errors (#128163) (#128533)
149a674 
* ES|QL: Make skip_unavailable catch all errors (#128163)

* Make skip_unavailable catch all errors

(cherry picked from commit 8484b71)

# Conflicts:
#	x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/plugin/ClusterComputeHandler.java

* Fix test

* Test fixes
@smalyshev smalyshev deleted the skip-un-ftw branch May 28, 2025 15:06
@smalyshev smalyshev mentioned this pull request Jun 24, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/ES|QL AKA ESQL auto-backport Automatically create backport pull requests when merged >breaking :Search Foundations/CCS Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch v8.19.0 v9.1.0

3 participants

@smalyshev @elasticsearchmachine @dnhatn