Skip to content

Adding space_id field mapping to kibana reporting template#128336

Merged
ymao1 merged 6 commits intoelastic:mainfrom
ymao1:reporting-space-id
Jun 6, 2025
Merged

Adding space_id field mapping to kibana reporting template#128336
ymao1 merged 6 commits intoelastic:mainfrom
ymao1:reporting-space-id

Conversation

@ymao1
Copy link
Contributor

@ymao1 ymao1 commented May 22, 2025

Adding space_id field mapping to kibana reporting template to support filtering by space ID (related Kibana PR: elastic/kibana#221375)

@ymao1 ymao1 self-assigned this May 22, 2025
@ymao1 ymao1 added >non-issue v8.19.0 v9.1.0 auto-backport Automatically create backport pull requests when merged labels May 22, 2025
@ymao1 ymao1 marked this pull request as ready for review May 23, 2025 16:59
@elasticsearchmachine elasticsearchmachine added the needs:triage Requires assignment of a team area label label May 23, 2025
@ymao1 ymao1 added the :StorageEngine/Data streams Data streams and their lifecycles label May 23, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Data Management (obsolete) DO NOT USE. This team no longer exists. label May 23, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label May 23, 2025
Copy link
Contributor

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lukewhiting lukewhiting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@ymao1
Copy link
Contributor Author

ymao1 commented Jun 5, 2025

run elasticsearch-ci/8.19.0/bwc-snapshots

@ymao1
Copy link
Contributor Author

ymao1 commented Jun 5, 2025

run elasticsearch-ci/bwc-snapshots

@ymao1
Copy link
Contributor Author

ymao1 commented Jun 6, 2025

run elasticsearch-ci/part-1

@ymao1 ymao1 merged commit 930c5d4 into elastic:main Jun 6, 2025
18 checks passed
@ymao1 ymao1 deleted the reporting-space-id branch June 6, 2025 13:38
ymao1 added a commit to elastic/kibana that referenced this pull request Jun 6, 2025
…d in the current space. (#221375)

Resolves #219881

## Summary

* Saves `space_id` in the report source document when a report is
generated.
* Updated the `list` API to filter by `space_id` (if available). The
filter also includes documents where `space_id` is not populated in
order to maintain backwards compatibility with old reports that don't
include the `space_id` field. This is an internal API so this change
should be allowed.
* Associated Elasticsearch PR to add `space_id` to the report index
mapping: elastic/elasticsearch#128336

## To Verify
* On `main`, generate reports in different spaces
* Switch to this branch and generate more reports in different spaces
* Verify that you only see the new reports generated in the current
space + the old reports generated on `main` with no space id.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.19
ymao1 added a commit to ymao1/elasticsearch that referenced this pull request Jun 6, 2025
…#128336)

* Adding space id to report template

* Incrementing stack template registry version
ymao1 added a commit to ymao1/kibana that referenced this pull request Jun 6, 2025
…d in the current space. (elastic#221375)

Resolves elastic#219881

## Summary

* Saves `space_id` in the report source document when a report is
generated.
* Updated the `list` API to filter by `space_id` (if available). The
filter also includes documents where `space_id` is not populated in
order to maintain backwards compatibility with old reports that don't
include the `space_id` field. This is an internal API so this change
should be allowed.
* Associated Elasticsearch PR to add `space_id` to the report index
mapping: elastic/elasticsearch#128336

## To Verify
* On `main`, generate reports in different spaces
* Switch to this branch and generate more reports in different spaces
* Verify that you only see the new reports generated in the current
space + the old reports generated on `main` with no space id.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
(cherry picked from commit a55c72d)

# Conflicts:
#	x-pack/platform/plugins/private/reporting/server/routes/common/jobs/jobs_query.test.ts
elasticsearchmachine pushed a commit that referenced this pull request Jun 6, 2025
#129061)

* Adding space id to report template

* Incrementing stack template registry version
mridula-s109 pushed a commit to mridula-s109/elasticsearch that referenced this pull request Jun 9, 2025
…#128336)

* Adding space id to report template

* Incrementing stack template registry version
pmuellr pushed a commit to pmuellr/kibana that referenced this pull request Jun 11, 2025
…d in the current space. (elastic#221375)

Resolves elastic#219881

## Summary

* Saves `space_id` in the report source document when a report is
generated.
* Updated the `list` API to filter by `space_id` (if available). The
filter also includes documents where `space_id` is not populated in
order to maintain backwards compatibility with old reports that don't
include the `space_id` field. This is an internal API so this change
should be allowed.
* Associated Elasticsearch PR to add `space_id` to the report index
mapping: elastic/elasticsearch#128336

## To Verify
* On `main`, generate reports in different spaces
* Switch to this branch and generate more reports in different spaces
* Verify that you only see the new reports generated in the current
space + the old reports generated on `main` with no space id.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
valeriy42 pushed a commit to valeriy42/elasticsearch that referenced this pull request Jun 12, 2025
…#128336)

* Adding space id to report template

* Incrementing stack template registry version
nickpeihl pushed a commit to nickpeihl/kibana that referenced this pull request Jun 12, 2025
…d in the current space. (elastic#221375)

Resolves elastic#219881

## Summary

* Saves `space_id` in the report source document when a report is
generated.
* Updated the `list` API to filter by `space_id` (if available). The
filter also includes documents where `space_id` is not populated in
order to maintain backwards compatibility with old reports that don't
include the `space_id` field. This is an internal API so this change
should be allowed.
* Associated Elasticsearch PR to add `space_id` to the report index
mapping: elastic/elasticsearch#128336

## To Verify
* On `main`, generate reports in different spaces
* Switch to this branch and generate more reports in different spaces
* Verify that you only see the new reports generated in the current
space + the old reports generated on `main` with no space id.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged >non-issue :StorageEngine/Data streams Data streams and their lifecycles Team:Data Management (obsolete) DO NOT USE. This team no longer exists. v8.19.0 v9.1.0

4 participants