DirectIOIT requires a filesystem that supports Direct IO.#128524
Merged
ChrisHegarty merged 1 commit intoelastic:lucene_snapshotfrom May 28, 2025
Merged
DirectIOIT requires a filesystem that supports Direct IO.#128524ChrisHegarty merged 1 commit intoelastic:lucene_snapshotfrom
ChrisHegarty merged 1 commit intoelastic:lucene_snapshotfrom
Conversation
Collaborator
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
Contributor
Author
|
Without this change we encounter failures like: |
Member
|
Shouldn't this check be within Elasticsearch? ES should work regardless of what the underlying file system is, using direct io opportunistically |
Contributor
Author
|
While the Elasticsearch CI builds and tests on a tmpfs, /dev/shm/bk, which does not support O_DIRECT, there are "periodic" builds/tests that use a "real" file-system. So there is coverage for directIO in "the system", just not on every PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DirectIOIT requires a filesystem that supports Direct IO.
The Elasticsearch CI builds and tests on a tmpfs,
/dev/shm/bk, which does not supportO_DIRECT.relates #128370