Bugfix: Prevent invalid privileges in manage roles privilege#128532
Merged
elasticsearchmachine merged 14 commits intoelastic:mainfrom May 29, 2025
Merged
Bugfix: Prevent invalid privileges in manage roles privilege#128532elasticsearchmachine merged 14 commits intoelastic:mainfrom
elasticsearchmachine merged 14 commits intoelastic:mainfrom
Conversation
gmjehovich
added
>bug
:Security/Authorization
Collaborator
|
Hi @gmjehovich, I've created a changelog YAML for you. |
n1v0lg
added
v8.19.0
auto-backport
n1v0lg
approved these changes
May 28, 2025
Contributor
n1v0lg
left a comment
n1v0lg
left a comment
There was a problem hiding this comment.
LGTM! Nice work 🚀 A couple comments but nothing that requires another round of review.
...t/java/org/elasticsearch/xpack/core/security/authz/privilege/ManageRolesPrivilegesTests.java
Outdated
Show resolved
Hide resolved
...t/java/org/elasticsearch/xpack/core/security/authz/privilege/ManageRolesPrivilegesTests.java
Show resolved
Hide resolved
...ity-trial/src/javaRestTest/java/org/elasticsearch/xpack/security/role/BulkPutRoleRestIT.java
Show resolved
Hide resolved
...ity-trial/src/javaRestTest/java/org/elasticsearch/xpack/security/role/BulkPutRoleRestIT.java
Show resolved
Hide resolved
n1v0lg
reviewed
May 28, 2025
...t/java/org/elasticsearch/xpack/core/security/authz/privilege/ManageRolesPrivilegesTests.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Nikolaj Volgushev <n1v0lg@users.noreply.github.com>
Co-authored-by: Nikolaj Volgushev <n1v0lg@users.noreply.github.com>
Co-authored-by: Nikolaj Volgushev <n1v0lg@users.noreply.github.com>
…security/authz/privilege/ManageRolesPrivilegesTests.java Co-authored-by: Nikolaj Volgushev <n1v0lg@users.noreply.github.com>
gmjehovich
force-pushed
the
managed-role-bug
branch
from
ac89b49 to
33b17cd
Compare
gmjehovich
added
the
auto-merge-without-approval
Collaborator
|
Hi @gmjehovich, I've updated the changelog YAML for you. |
Collaborator
|
Pinging @elastic/es-security (Team:Security) |
gmjehovich
force-pushed
the
managed-role-bug
branch
from
370ac83 to
c641de1
Compare
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
joshua-adams-1
pushed a commit
to joshua-adams-1/elasticsearch
that referenced
this pull request
Jun 3, 2025
…#128532) This PR addresses the bug reported in [elastic#127496](elastic#127496) **Changes:** - Added validation logic in `ConfigurableClusterPrivileges` to ensure privileges defined for a global cluster manage role privilege are valid - Added unit test to `ManageRolePrivilegesTest` to ensure invalid privilege is caught during role creation - Updated `BulkPutRoleRestIT` to assert that an error is thrown and that the role is not created. Both existing and new unit/integration tests passed locally.
gmjehovich
added a commit
to gmjehovich/elasticsearch
that referenced
this pull request
Jun 3, 2025
…#128532) This PR addresses the bug reported in [elastic#127496](elastic#127496) **Changes:** - Added validation logic in `ConfigurableClusterPrivileges` to ensure privileges defined for a global cluster manage role privilege are valid - Added unit test to `ManageRolePrivilegesTest` to ensure invalid privilege is caught during role creation - Updated `BulkPutRoleRestIT` to assert that an error is thrown and that the role is not created. Both existing and new unit/integration tests passed locally.
Samiul-TheSoccerFan
pushed a commit
to Samiul-TheSoccerFan/elasticsearch
that referenced
this pull request
Jun 5, 2025
…#128532) This PR addresses the bug reported in [elastic#127496](elastic#127496) **Changes:** - Added validation logic in `ConfigurableClusterPrivileges` to ensure privileges defined for a global cluster manage role privilege are valid - Added unit test to `ManageRolePrivilegesTest` to ensure invalid privilege is caught during role creation - Updated `BulkPutRoleRestIT` to assert that an error is thrown and that the role is not created. Both existing and new unit/integration tests passed locally.
gmjehovich
added a commit
that referenced
this pull request
Jun 9, 2025
This PR addresses the bug reported in [#127496](#127496) **Changes:** - Added validation logic in `ConfigurableClusterPrivileges` to ensure privileges defined for a global cluster manage role privilege are valid - Added unit test to `ManageRolePrivilegesTest` to ensure invalid privilege is caught during role creation - Updated `BulkPutRoleRestIT` to assert that an error is thrown and that the role is not created. Both existing and new unit/integration tests passed locally.
This was referenced Jun 9, 2025
gmjehovich
added a commit
to gmjehovich/elasticsearch
that referenced
this pull request
Jun 9, 2025
…elastic#128847) This PR addresses the bug reported in [elastic#127496](elastic#127496) **Changes:** - Added validation logic in `ConfigurableClusterPrivileges` to ensure privileges defined for a global cluster manage role privilege are valid - Added unit test to `ManageRolePrivilegesTest` to ensure invalid privilege is caught during role creation - Updated `BulkPutRoleRestIT` to assert that an error is thrown and that the role is not created. Both existing and new unit/integration tests passed locally.
gmjehovich
added a commit
to gmjehovich/elasticsearch
that referenced
this pull request
Jun 9, 2025
…elastic#128847) This PR addresses the bug reported in [elastic#127496](elastic#127496) **Changes:** - Added validation logic in `ConfigurableClusterPrivileges` to ensure privileges defined for a global cluster manage role privilege are valid - Added unit test to `ManageRolePrivilegesTest` to ensure invalid privilege is caught during role creation - Updated `BulkPutRoleRestIT` to assert that an error is thrown and that the role is not created. Both existing and new unit/integration tests passed locally.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jun 9, 2025
…) (#129155) This PR addresses the bug reported in [#127496](#127496) **Changes:** - Added validation logic in `ConfigurableClusterPrivileges` to ensure privileges defined for a global cluster manage role privilege are valid - Added unit test to `ManageRolePrivilegesTest` to ensure invalid privilege is caught during role creation - Updated `BulkPutRoleRestIT` to assert that an error is thrown and that the role is not created. Both existing and new unit/integration tests passed locally.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jun 9, 2025
…) (#129156) This PR addresses the bug reported in [#127496](#127496) **Changes:** - Added validation logic in `ConfigurableClusterPrivileges` to ensure privileges defined for a global cluster manage role privilege are valid - Added unit test to `ManageRolePrivilegesTest` to ensure invalid privilege is caught during role creation - Updated `BulkPutRoleRestIT` to assert that an error is thrown and that the role is not created. Both existing and new unit/integration tests passed locally.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jun 9, 2025
#128626) This PR addresses the bug reported in [#127496](#127496) **Changes:** - Added validation logic in `ConfigurableClusterPrivileges` to ensure privileges defined for a global cluster manage role privilege are valid - Added unit test to `ManageRolePrivilegesTest` to ensure invalid privilege is caught during role creation - Updated `BulkPutRoleRestIT` to assert that an error is thrown and that the role is not created. Both existing and new unit/integration tests passed locally. Co-authored-by: Joe Gallo <joe.gallo@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the bug reported in #127496
Changes:
ConfigurableClusterPrivilegesto ensure privileges defined for a global cluster manage role privilege are validManageRolePrivilegesTestto ensure invalid privilege is caught during role creationBulkPutRoleRestITto assert that an error is thrown and that the role is not created.Both existing and new unit/integration tests passed locally.