NPE on batched query execution when the request is part of PIT with alias filters#128552
Merged
drempapis merged 19 commits intoelastic:8.19from Jun 3, 2025
Merged
Conversation
drempapis
added
>bug
Team:Search Foundations
Collaborator
|
Hi @drempapis, I've created a changelog YAML for you. |
…/elasticsearch into fix/batch_query_pit_with_alias
Collaborator
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
…/elasticsearch into fix/batch_query_pit_with_alias
javanna
reviewed
Jun 2, 2025
server/src/internalClusterTest/java/org/elasticsearch/action/search/PointInTimeIT.java
Outdated
Show resolved
Hide resolved
| public void testIndexWithAlias() { | ||
| String indexName = "index_1"; | ||
| String alias = "alias_1"; | ||
| assertAcked(indicesAdmin().prepareCreate(indexName).setSettings(indexSettings(10, 0)).addAlias(new Alias(alias))); |
Contributor
There was a problem hiding this comment.
Did this test fail without the fix? I was unclear on whether we need to add a filter to the alias, or not.
Contributor
Author
There was a problem hiding this comment.
Yes, the filter is required. I inadvertently committed a version that did not include the filtering logic. Updating with some enhancements
javanna
approved these changes
Jun 2, 2025
Contributor
javanna
left a comment
javanna
left a comment
There was a problem hiding this comment.
I left a couple of comments on the test, the fix makes sense to me. LGTM, no need for another round once the comments are addressed.
server/src/internalClusterTest/java/org/elasticsearch/action/search/PointInTimeIT.java
Outdated
Show resolved
Hide resolved
server/src/internalClusterTest/java/org/elasticsearch/action/search/PointInTimeIT.java
Outdated
Show resolved
Hide resolved
This was referenced Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As in the description of the issue (#128270)
In this work, the
namedWriteableRegistryis propagated to theisPartOfPITmethod to facilitate context retrieval.