Add bucketedSort based on int#128848
Merged
elasticsearchmachine merged 7 commits intoelastic:mainfrom Jun 3, 2025
Merged
Conversation
Follow up on elastic#127968
Collaborator
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
Collaborator
|
Hi @mayya-sharipova, I've created a changelog YAML for you. |
benwtrent
approved these changes
Jun 3, 2025
john-wagster
reviewed
Jun 3, 2025
| } | ||
| } | ||
|
|
||
| public abstract static class ForInts extends BucketedSort { |
Contributor
There was a problem hiding this comment.
there's a BucketedSortForLongsTests should there also be a BucketedSortForIntsTests now?
john-wagster
approved these changes
Jun 3, 2025
Contributor
john-wagster
left a comment
There was a problem hiding this comment.
left one comment; otherwise lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add bucketedSort on Int
Follow up on #127968