Update AbstractXContentParser to support parsers that don't provide text characters#129005
Merged
Mikep86 merged 6 commits intoelastic:mainfrom Jun 6, 2025
Merged
Conversation
Mikep86
added
>bug
:Core/Infra/Core
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
Collaborator
|
Hi @Mikep86, I've created a changelog YAML for you. |
JVerwolf
approved these changes
Jun 5, 2025
Contributor
JVerwolf
left a comment
JVerwolf
left a comment
There was a problem hiding this comment.
LGTM. I reverted the change and ran the test to confirm this fails as expected. Might want to add another to check the false case too. Thanks for the fix!
libs/x-content/src/test/java/org/elasticsearch/xcontent/MapXContentParserTests.java
Show resolved
Hide resolved
Contributor
Author
|
@elasticmachine update branch |
Contributor
Author
|
@elasticmachine update branch |
Mikep86
added a commit
to Mikep86/elasticsearch
that referenced
this pull request
Jun 6, 2025
…ext characters (elastic#129005) (cherry picked from commit 5ee6dfa)
Mikep86
added a commit
to Mikep86/elasticsearch
that referenced
this pull request
Jun 6, 2025
…ext characters (elastic#129005) (cherry picked from commit 5ee6dfa)
Mikep86
added a commit
to Mikep86/elasticsearch
that referenced
this pull request
Jun 6, 2025
…ext characters (elastic#129005) (cherry picked from commit 5ee6dfa)
Mikep86
added a commit
to Mikep86/elasticsearch
that referenced
this pull request
Jun 6, 2025
…ext characters (elastic#129005) (cherry picked from commit 5ee6dfa)
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jun 9, 2025
valeriy42
pushed a commit
to valeriy42/elasticsearch
that referenced
this pull request
Jun 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
AbstractXContentParserto support parsers that don't provide text characters. Previously,AbstractXContentParserassumed that all parsers implementedtextCharacters(),textOffset(), andtextLength(), which isn't true.