Skip to content

transport: edit TransportConnectionListener for close exceptions (#12…#129383

Merged
schase-es merged 1 commit intoelastic:8.19from
schase-es:backport/8.19/129015-transport-connection-listener-close-exceptions
Jun 13, 2025
Merged

transport: edit TransportConnectionListener for close exceptions (#12…#129383
schase-es merged 1 commit intoelastic:8.19from
schase-es:backport/8.19/129015-transport-connection-listener-close-exceptions

Conversation

@schase-es
Copy link
Contributor

Backports the following commit for ES-12007 to 8.19:

  • transport: edit TransportConnectionListener for close exceptions 129360
…stic#129015)

The TransportConnectionListener interface has previously included the
Transport.Connection being closed and unregistered in its onNodeDisconnected
callback. This is not in use, and can be removed as it is also available in the
onConnectionClosed callback. It is being replaced with a Nullable exception that
caused the close. This is being used in pending work (ES-11448) to differentiate
network issues from node restarts.

Backports PR 129015/ES-12007 to 8.19
@schase-es schase-es requested a review from nicktindall June 13, 2025 01:57
@schase-es schase-es added >non-issue :Distributed/Network Http and internode communication implementations backport v8.19.0 labels Jun 13, 2025
Copy link
Contributor

@nicktindall nicktindall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schase-es schase-es merged commit 9ff05a1 into elastic:8.19 Jun 13, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport :Distributed/Network Http and internode communication implementations >non-issue v8.19.0

2 participants