Serialize default index_options for semantic_text fields#129877
Closed
kderusso wants to merge 1 commit intoelastic:mainfrom
Closed
Serialize default index_options for semantic_text fields#129877kderusso wants to merge 1 commit intoelastic:mainfrom
kderusso wants to merge 1 commit intoelastic:mainfrom
Conversation
Member
Author
|
Closing as this introduces inconsistency in serialized models. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue from #119967 where the default
index_optionswere not displayed wheninclude_defaultsis set to true.Part of this fix requires serializing the
model_settingsearlier so they're accessible when we're performing serialization checks forindex_options.Here is an example of how to test this: