Add support for RLIKE (LIST) with pushdown#129929
Merged
julian-elastic merged 11 commits intoelastic:mainfrom Jul 15, 2025
Merged
Add support for RLIKE (LIST) with pushdown#129929julian-elastic merged 11 commits intoelastic:mainfrom
julian-elastic merged 11 commits intoelastic:mainfrom
Conversation
Contributor
|
🔍 Preview links for changed docs:
🔔 The preview site may take up to 3 minutes to finish building. These links will become live once it completes. |
Collaborator
|
Hi @julian-elastic, I've created a changelog YAML for you. |
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
nik9000
approved these changes
Jun 25, 2025
| if (regexMatch.pattern() instanceof WildcardPatternList) { | ||
| // This optimization is not supported for WildcardPatternList for now | ||
| if (regexMatch.pattern() instanceof WildcardPatternList || regexMatch.pattern() instanceof RLikePatternList) { | ||
| // This optimization is not supported for WildcardPatternList and RLikePatternList for now |
Member
There was a problem hiding this comment.
I suppose this is next in line!
777699a to
bb06a63
Compare
Contributor
🔍 Preview links for changed docs |
89f035c to
2ffef9b
Compare
2ffef9b to
c0c6bad
Compare
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
julian-elastic
added a commit
to julian-elastic/elasticsearch
that referenced
this pull request
Jul 15, 2025
Adds support for RLIKE function alternative syntax with a list of patterns.
Examples:
ROW message = "foobar"
| WHERE message RLIKE ("foo.*", "bar.")
The new syntax is documented as part of the existing RLIKE function documentation. We will use the existing RLike java implementation for existing cases using the old syntax and one list argument case to improve mixed cluster compatibility.
The RLikeList is pushed down as a single Automaton to improve performance.
(cherry picked from commit f0c30f2)
# Conflicts:
# x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/action/EsqlCapabilities.java
# x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/parser/EsqlBaseParser.interp
# x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/parser/EsqlBaseParser.java
julian-elastic
added a commit
to julian-elastic/elasticsearch
that referenced
this pull request
Jul 15, 2025
Adds support for RLIKE function alternative syntax with a list of patterns.
Examples:
ROW message = "foobar"
| WHERE message RLIKE ("foo.*", "bar.")
The new syntax is documented as part of the existing RLIKE function documentation. We will use the existing RLike java implementation for existing cases using the old syntax and one list argument case to improve mixed cluster compatibility.
The RLikeList is pushed down as a single Automaton to improve performance.
(cherry picked from commit f0c30f2)
# Conflicts:
# docs/reference/query-languages/esql/_snippets/operators/detailedDescription/rlike.md
# x-pack/plugin/esql/src/main/antlr/parser/Expression.g4
# x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/action/EsqlCapabilities.java
# x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/scalar/string/regex/RLike.java
# x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/parser/EsqlBaseParser.interp
# x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/parser/EsqlBaseParser.java
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for RLIKE function alternative syntax with a list of patterns.
Examples:
The new syntax is documented as part of the existing RLIKE function documentation. We will use the existing RLike java implementation for existing cases using the old syntax and one list argument case to improve mixed cluster compatibility.
The RLikeList is pushed down as a single Automaton to improve performance.