Simplified Linear & RRF Retrievers - Return error on empty fields param#129962
Merged
Mikep86 merged 8 commits intoelastic:mainfrom Jun 24, 2025
Merged
Simplified Linear & RRF Retrievers - Return error on empty fields param#129962Mikep86 merged 8 commits intoelastic:mainfrom
Mikep86 merged 8 commits intoelastic:mainfrom
Conversation
Collaborator
|
Pinging @elastic/search-eng (Team:SearchOrg) |
Collaborator
|
Pinging @elastic/search-relevance (Team:Search - Relevance) |
Collaborator
|
Hi @Mikep86, I've created a changelog YAML for you. |
ioanatia
approved these changes
Jun 24, 2025
Contributor
Author
|
@elasticmachine update branch |
Contributor
Author
|
@elasticmachine update branch |
Collaborator
💚 Backport successful
|
Mikep86
added a commit
to Mikep86/elasticsearch
that referenced
this pull request
Jun 24, 2025
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jun 25, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jun 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the simplified
linear&rrfretrievers to return an error when thefieldsparam is empty:Previously, this would query all fields specified by
index.query.default_field, but this creates a potential future problem with supporting combinations ofqueryandretrievers, like this:In contrast, this should (at most) only execute the custom sub-retrievers and not query any fields for "Harry Potter". Returning an error for now when the
fieldsparam is empty gives us more options for how to combinequeryandretrieversin the future.