Support returning default index_options for semantic_text fields when include_defaults is true #129967
Merged
kderusso merged 13 commits intoelastic:mainfrom Jun 26, 2025
Merged
Conversation
Collaborator
|
Hi @kderusso, I've created a changelog YAML for you. |
Collaborator
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
Mikep86
reviewed
Jun 25, 2025
Contributor
Mikep86
left a comment
There was a problem hiding this comment.
Approach looks good overall, I have some follow-up questions about null serialization though.
...ference/src/main/java/org/elasticsearch/xpack/inference/mapper/SemanticTextIndexOptions.java
Show resolved
Hide resolved
...nference/src/main/java/org/elasticsearch/xpack/inference/mapper/SemanticTextFieldMapper.java
Outdated
Show resolved
Hide resolved
...nference/src/main/java/org/elasticsearch/xpack/inference/mapper/SemanticTextFieldMapper.java
Show resolved
Hide resolved
...e/src/yamlRestTest/resources/rest-api-spec/test/inference/10_semantic_text_field_mapping.yml
Outdated
Show resolved
Hide resolved
Contributor
|
Also, can we add a test showing that |
Member
Author
Contributor
|
@kderusso This test doesn't cover what I had in mind. I think it would be good to check that if we provide a mapping like: PUT my-index
{
"mappings": {
"properties": {
"dense_inference": {
"type": "semantic_text",
"inference_id": "some_dense_inference_id",
"index_options": {
<BBQ index options that match defaults>
}
}
}
}
}The |
Mikep86
approved these changes
Jun 26, 2025
Contributor
Mikep86
left a comment
There was a problem hiding this comment.
LGTM, thanks for the changes!
smalyshev
pushed a commit
to smalyshev/elasticsearch
that referenced
this pull request
Jun 27, 2025
… include_defaults is true (elastic#129967)
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jul 3, 2025
… include_defaults is true (elastic#129967)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue from #119967 where the default
index_optionswere not displayed wheninclude_defaultsis set to true.Part of this fix requires serializing the
model_settingsearlier so they're accessible when we're performing serialization checks forindex_options.Here is an example of how to test this: