Ensure vectors are always included in reindex actions#130834
Merged
jimczi merged 4 commits intoelastic:mainfrom Jul 9, 2025
Merged
Ensure vectors are always included in reindex actions#130834jimczi merged 4 commits intoelastic:mainfrom
jimczi merged 4 commits intoelastic:mainfrom
Conversation
This change modifies reindex behavior to always include vector fields, even if the target index omits embeddings from _source. This prepares for scenarios where embeddings may be automatically excluded (elastic#130382)
elasticsearchmachine
added
the
Team:Search Relevance
Collaborator
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
Collaborator
|
Hi @jimczi, I've created a changelog YAML for you. |
benwtrent
approved these changes
Jul 8, 2025
Member
benwtrent
left a comment
benwtrent
left a comment
There was a problem hiding this comment.
Well, that was simpler than I thought it would be!
| assertHitCount(prepareSearch(destIndexName).setSize(0), 4); | ||
| } | ||
|
|
||
| public void testReindexIncludeVectors() throws Exception { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change modifies reindex behavior to always include vector fields, even if the target index omits embeddings from _source. This prepares for scenarios where embeddings may be automatically excluded (#130382).