ES|QL: Infer score mode from collector#131006
Merged
ioanatia merged 2 commits intoelastic:mainfrom Jul 10, 2025
Merged
Conversation
ioanatia
added
auto-backport
elasticsearchmachine
added
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
jimczi
approved these changes
Jul 10, 2025
Contributor
jimczi
left a comment
jimczi
left a comment
There was a problem hiding this comment.
Using the collector to determine the score mode is the best approach, LGTM!
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
ioanatia
added a commit
to ioanatia/elasticsearch
that referenced
this pull request
Jul 10, 2025
Contributor
|
Not for now, but maybe as a follow up; does it make sense to add a score mode to the profile output of the LuceneOperator, so that it could be checked and asserted in an IT ? |
Contributor
Author
yes it does - but it's not trivial at all. |
ioanatia
added a commit
to ioanatia/elasticsearch
that referenced
this pull request
Jul 11, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 11, 2025
ioanatia
added a commit
that referenced
this pull request
Jul 11, 2025
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jul 17, 2025
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brings back the optimization from #125930