Skip to content

Add exception for perform embedding inference requests with query provided#131641

Merged
dan-rubinstein merged 6 commits intoelastic:mainfrom
dan-rubinstein:embedding-inference-block-query
Sep 17, 2025
Merged

Add exception for perform embedding inference requests with query provided#131641
dan-rubinstein merged 6 commits intoelastic:mainfrom
dan-rubinstein:embedding-inference-block-query

Conversation

@dan-rubinstein
Copy link
Member

@dan-rubinstein dan-rubinstein commented Jul 21, 2025

Issue - #131011

This change adds a check that throws an exception if an embedding (text or sparse embedding) perform inference request includes a query.

Testing:

  • Unit tests
  • Created a text embedding endpoint, called inference with query and made sure it failed. Called inference without query and made sure it succeeded.
  • Created a sparse embedding endpoint, called inference with query and made sure it failed. Called inference without query and made sure it succeeded.
@dan-rubinstein dan-rubinstein added >bug :ml Machine learning Team:ML Meta label for the ML team v9.2.0 labels Jul 21, 2025
@elasticsearchmachine
Copy link
Collaborator

Hi @dan-rubinstein, I've created a changelog YAML for you.

@cla-checker-service
Copy link

cla-checker-service bot commented Jul 21, 2025

💚 CLA has been signed

@dan-rubinstein dan-rubinstein marked this pull request as ready for review July 21, 2025 20:25
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@dan-rubinstein
Copy link
Member Author

@elasticmachine merge upstream

@dan-rubinstein dan-rubinstein merged commit 659b132 into elastic:main Sep 17, 2025
35 checks passed
gmjehovich pushed a commit to gmjehovich/elasticsearch that referenced this pull request Sep 18, 2025
…vided (elastic#131641)

* Add exception for perform embedding inference requests with query provided

* Update docs/changelog/131641.yaml

* [CI] Auto commit changes from spotless

---------

Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co>
Co-authored-by: Pat Whelan <pat.whelan@elastic.co>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>bug :ml Machine learning Team:ML Meta label for the ML team v9.2.0

4 participants