Add extension points to remediate index metadata in during snapshot restore#131706
Conversation
jbaiera
added
:Distributed/Snapshot/Restore
elasticsearchmachine
added
the
Team:Distributed Coordination (obsolete)
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
|
Hi @jbaiera, I've created a changelog YAML for you. |
elasticsearchmachine
added
the
serverless-linked
DaveCTurner
left a comment
DaveCTurner
left a comment
There was a problem hiding this comment.
Production change seems fine to me. However I don't think SnapshotResiliencyTests are quite the right place for this. Instead, could we add a test case to RestoreSnapshotIT (or maybe another AbstractSnapshotIntegTestCase?) covering this specific change. I'd want us to be injecting the transformer via a plugin (i.e. overriding org.elasticsearch.test.ESIntegTestCase#nodePlugins).
DaveCTurner
left a comment
DaveCTurner
left a comment
There was a problem hiding this comment.
Oh yes also this is a very temporary change right? We can drop it as soon as all the affected snapshots have expired. It'd be worth mentioning this in the javadocs.
server/src/main/java/org/elasticsearch/snapshots/IndexMetadataRestoreTransformer.java
Show resolved
Hide resolved
Add javadoc to new interface, move tests into their own locate outside the resiliency tests.
4 participants
Adds a new SPI to allow plugins to hook into the snapshot restore process in order to remediate index metadata before accepting it into the cluster state.