[ES|QL] Consider min/max from predicates when transform date_trunc/bucket to round_to option 2#132143
Merged
fang-xing-esql merged 13 commits intoelastic:mainfrom Aug 6, 2025
Conversation
Collaborator
|
Hi @fang-xing-esql, I've created a changelog YAML for you. |
elasticsearchmachine
added
the
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
astefan
approved these changes
Aug 6, 2025
Contributor
astefan
left a comment
astefan
left a comment
There was a problem hiding this comment.
LGTM
I think this is the better approach than the one of LocalSurrogateExpression. The code is easier to read/follow and the logic makes more sense like this. Thank you!
Member
Author
|
Thanks a lot for reviewing @astefan ! |
nik9000
approved these changes
Aug 6, 2025
Member
nik9000
left a comment
nik9000
left a comment
There was a problem hiding this comment.
Progress!
I think it'd be nice to have the rule be pluggable in some way - there are other things we're going to do this with. But let's do that when have another one or two.
fang-xing-esql
deleted the
datetrunc-roundto-with-min-max-from-predicates-2
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the second option to implement considering
min/maxfrom predicates when transformdate_trunc/buckettoround_to. Instead of doing the transformation within each function by implementingLocalSurrogateExpression#131341 , this approach create a dedicated rule to transformdate_trunc/buckettoround_to.