Update EIS sparse and dense embedding max batch size to 16#132646
Merged
Update EIS sparse and dense embedding max batch size to 16#132646
Conversation
jaybcee
added
auto-backport
timgrein
approved these changes
Aug 11, 2025
Contributor
timgrein
left a comment
timgrein
left a comment
There was a problem hiding this comment.
Can you add maybe a comment with the context why we set it to 16? I see this could cause some confusion in the future why we went down from 512 to 16. Otherwise LGTM 🚢
prwhelan
approved these changes
Aug 11, 2025
elasticsearchmachine
added
the
needs:triage
prwhelan
added
>non-issue
:ml
elasticsearchmachine
removed
the
needs:triage
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
Collaborator
|
Hi @jaybcee, I've created a changelog YAML for you. |
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
Member
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
sarog
pushed a commit
to portsbuild/elasticsearch
that referenced
this pull request
Sep 11, 2025
…32646) (elastic#132855) (cherry picked from commit 81b4cce) # Conflicts: # x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/elastic/ElasticInferenceService.java Co-authored-by: Jonathan Buttner <56361221+jonathan-buttner@users.noreply.github.com>
sarog
pushed a commit
to portsbuild/elasticsearch
that referenced
this pull request
Sep 19, 2025
…32646) (elastic#132855) (cherry picked from commit 81b4cce) # Conflicts: # x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/elastic/ElasticInferenceService.java Co-authored-by: Jonathan Buttner <56361221+jonathan-buttner@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In EIS, we've determined that the best batch size at the moment is of size 16, not 512. Updating the maximum batch size to reflect reality. We previously thought it would not necessarily need to be set.
Ref: https://github.com/elastic/search-team/issues/10719