[ML] Ensuring only a single request executor object is created#133424
Merged
jonathan-buttner merged 5 commits intoelastic:mainfrom Aug 27, 2025
Merged
Conversation
jonathan-buttner
added
>non-issue
:ml
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
Collaborator
|
Hi @jonathan-buttner, I've created a changelog YAML for you. |
| } | ||
|
|
||
| public Sender createSender() { | ||
| return httpRequestSender; |
Contributor
Author
There was a problem hiding this comment.
We don't really need this method or the class anymore. We can do additional refactoring but I wanted to keep the fix in a small PR. This method is used a lot throughout the tests.
Member
There was a problem hiding this comment.
Yeah maybe we should (eventually) replace this whole class with a Lazy or a SetOnce so we don't have to have a countdown latch in a constructor, but I see that we do that in SenderService regardless so there's no change there I suppose
prwhelan
approved these changes
Aug 25, 2025
| } | ||
|
|
||
| public Sender createSender() { | ||
| return httpRequestSender; |
Member
There was a problem hiding this comment.
Yeah maybe we should (eventually) replace this whole class with a Lazy or a SetOnce so we don't have to have a countdown latch in a constructor, but I see that we do that in SenderService regardless so there's no change there I suppose
jonathan-buttner
added a commit
to jonathan-buttner/elasticsearch
that referenced
this pull request
Aug 27, 2025
…ic#133424) * Ensuring only a single request executor thread is started * Reverting test changes * Update docs/changelog/133424.yaml
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 27, 2025
…) (#133670) * Ensuring only a single request executor thread is started * Reverting test changes * Update docs/changelog/133424.yaml
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 27, 2025
…) (#133669) * Ensuring only a single request executor thread is started * Reverting test changes * Update docs/changelog/133424.yaml
jonathan-buttner
added a commit
to jonathan-buttner/elasticsearch
that referenced
this pull request
Aug 28, 2025
…ic#133424) * Ensuring only a single request executor thread is started * Reverting test changes * Update docs/changelog/133424.yaml (cherry picked from commit d5a9343) # Conflicts: # x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/external/amazonbedrock/AmazonBedrockRequestSenderTests.java
This was referenced Aug 28, 2025
jonathan-buttner
added a commit
to jonathan-buttner/elasticsearch
that referenced
this pull request
Aug 28, 2025
…ic#133424) * Ensuring only a single request executor thread is started * Reverting test changes * Update docs/changelog/133424.yaml (cherry picked from commit d5a9343) # Conflicts: # x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/external/amazonbedrock/AmazonBedrockRequestSenderTests.java
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
jonathan-buttner
added a commit
to jonathan-buttner/elasticsearch
that referenced
this pull request
Aug 28, 2025
…ic#133424) * Ensuring only a single request executor thread is started * Reverting test changes * Update docs/changelog/133424.yaml (cherry picked from commit d5a9343) # Conflicts: # x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/external/http/sender/HttpRequestSender.java # x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/external/amazonbedrock/AmazonBedrockRequestSenderTests.java
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 28, 2025
…) (#133715) * Ensuring only a single request executor thread is started * Reverting test changes * Update docs/changelog/133424.yaml (cherry picked from commit d5a9343) # Conflicts: # x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/external/amazonbedrock/AmazonBedrockRequestSenderTests.java
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 28, 2025
…) (#133716) * Ensuring only a single request executor thread is started * Reverting test changes * Update docs/changelog/133424.yaml (cherry picked from commit d5a9343) # Conflicts: # x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/external/amazonbedrock/AmazonBedrockRequestSenderTests.java
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 28, 2025
…) (#133721) * Ensuring only a single request executor thread is started * Reverting test changes * Update docs/changelog/133424.yaml (cherry picked from commit d5a9343) # Conflicts: # x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/external/http/sender/HttpRequestSender.java # x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/external/amazonbedrock/AmazonBedrockRequestSenderTests.java
sarog
pushed a commit
to portsbuild/elasticsearch
that referenced
this pull request
Sep 11, 2025
…ic#133424) (elastic#133670) * Ensuring only a single request executor thread is started * Reverting test changes * Update docs/changelog/133424.yaml
sarog
pushed a commit
to portsbuild/elasticsearch
that referenced
this pull request
Sep 19, 2025
…ic#133424) (elastic#133670) * Ensuring only a single request executor thread is started * Reverting test changes * Update docs/changelog/133424.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes sure only a single
HttpRequestSenderandRequestExecutorobject is created. There's been a bug where the first request to each integration would start a newRequestExecutorServicewhich would cause new threads to be scheduled.