Update DefBootstrap to handle Error from ClassValue

[jdconrad]

ClassValue.getFromHashMap wraps checked exceptions as Error, but we do not want to crash here because we could not process the type correctly as part of a Painless script, so we instead unwrap the Error and rethrow the original exception.

[elasticsearchmachine]

Pinging @elastic/es-core-infra (Team:Core/Infra)

[ldematte]

I think it would be great (if possible) to add a unit test that forces an Exception (checked) inside ClassValue.getFromHashMap to demonstrate this PR works as intended

[elasticsearchmachine]

Hi @jdconrad, I've created a changelog YAML for you.

[jdconrad]

@ldematte Thanks for the review! I will try to add a jdk25+ specific test.

Edit: On second thought, did you want something additional to the changes in DefBootstrapTests where this is indeed forced as an error?

[ldematte]

I see your point, the test you have basically already cover what is needed, showing that any exception does indeed get wrapped.
I was thinking about a test showing that when a (checked) exception is thrown in ClassValue.getFromHashMap, that exception is not wrapped anymore but it's instead a PainlessWrappedException.
But IDK how easy or difficult it is to do that, nor if this adds a great value, so I'll let you decide if and how you want to add such a test.

LGTM

[elasticsearchmachine]

💚 Backport successful

Status	Branch	Result
✅	9.1
✅	9.0
✅	8.18
✅	8.19