Remove Transfer-Encoding from HTTP request with no content#133775
Merged
mhl-b merged 12 commits intoelastic:mainfrom Sep 3, 2025
Merged
Remove Transfer-Encoding from HTTP request with no content#133775mhl-b merged 12 commits intoelastic:mainfrom
mhl-b merged 12 commits intoelastic:mainfrom
Conversation
mhl-b
added
>bug
:Distributed/Network
Collaborator
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
Collaborator
|
Hi @mhl-b, I've created a changelog YAML for you. |
…ch into empty-chunked-encoding
DaveCTurner
approved these changes
Sep 1, 2025
Contributor
DaveCTurner
left a comment
DaveCTurner
left a comment
There was a problem hiding this comment.
LGTM
Also deserves a backport to 9.1 since we're considering it a bug. I don't think it affects 8.19 tho, we did not apply the streaming bulk request changes there.
mhl-b
added
auto-backport
Collaborator
💚 Backport successful
|
mhl-b
added a commit
to mhl-b/elasticsearch
that referenced
this pull request
Sep 3, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we assume when
Transfer-Encoding: chunkedthere is non-zero payload. It appears not always true, #133408.This PR ensures that
Transfer-Encoding: chunkedalways has content by removing encoding from empty payload. When we receive HTTP request we look at the encoding, if it's chunked then we wait for the first chunk to see if it's empty. If that's the case we remove encoding and process request as non-chunked.