Add file extension metadata to cache miss counter from SharedBlobCacheService#134374
Add file extension metadata to cache miss counter from SharedBlobCacheService#134374tteofili merged 34 commits intoelastic:mainfrom
Conversation
tteofili
added
:Search Foundations/Search
|
Hi @tteofili, I've created a changelog YAML for you. |
elasticsearchmachine
added
the
Team:Search Foundations
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
…search into cachemiss_metric_filext
andreidan
left a comment
andreidan
left a comment
There was a problem hiding this comment.
Thanks Tommaso. This LGTM with one mention.
Also, should we open a linked serverless PR?
...ugin/blob-cache/src/main/java/org/elasticsearch/blobcache/shared/SharedBlobCacheService.java
Outdated
Show resolved
Hide resolved
elasticsearchmachine
added
the
serverless-linked
| @Nullable | ||
| public static boolean isLuceneExtension(String ext) { | ||
| return extensions.containsKey(ext); |
There was a problem hiding this comment.
nit: this is not nullable
There was a problem hiding this comment.
if I'm not mistaken, IndexFileNames#getExtension might return null in case the fileName doesn't contain a ., that's why I had put the @Nullable annotation.
There was a problem hiding this comment.
Oh yes. I see what you mean.
We should @Nullable the ext method parameter ++
Being on the method it indicates the method can return null.
...ugin/blob-cache/src/main/java/org/elasticsearch/blobcache/shared/SharedBlobCacheService.java
Outdated
Show resolved
Hide resolved
| return LuceneFilesExtensions.CFS.getExtension(); | ||
| } | ||
| try { | ||
| String extension = IndexFileNames.getExtension(resourceDescription); |
There was a problem hiding this comment.
extension can be null here
There was a problem hiding this comment.
this is considered in the if statement
if (LuceneFilesExtensions.isLuceneExtension(extension)) ...
so a null here will result in other extension.
...ugin/blob-cache/src/main/java/org/elasticsearch/blobcache/shared/SharedBlobCacheService.java
Outdated
Show resolved
Hide resolved
* upstream/main: Add additional logging to make spotting stats issues easier (elastic#133972) [ESQL] Clean up ESQL enrich landing page (elastic#134820) ES|QL: Make kibana docs for Query settings more consistent (elastic#134881) Add file extension metadata to cache miss counter from SharedBlobCacheService (elastic#134374) Add IT for num_reduced_phases with batched query execution (elastic#134312) Remove `SizeValue` (elastic#134871)
4 participants
This adds file extension metadata to cache miss counter when that's updated by
SharedBlobCacheService.In particular this updates the
es.blob_cache.miss_that_triggered_read.totalcounter with file extensions.At the moment, we don't introspect into compound files, we might do it or not in the future.