Propagates filter() to aggregation functions' surrogates

[ncordon]

When an aggregate expression can get replaced by a surrogate in the planner, we have to propagate the original filter() part. Example:

TOP(field, 1, "ASC") WHERE {{ some condition on field }}

gets replaced internally by a MIN(field) but we were losing the WHERE part

Fixes #134380

[elasticsearchmachine]

Hi @ncordon, I've created a changelog YAML for you.

[elasticsearchmachine]

Pinging @elastic/es-analytical-engine (Team:Analytics)

[ivancea]

Looks good, thanks!

[ivancea]

nit: I think there's an overload with suppliers here. Something like:

Suggested change

	Expression expression = randomFrom(
	buildLiteralExpression(testCase),
	buildDeepCopyOfFieldExpression(testCase),
	buildFieldExpression(testCase)
	);
	Expression expression = randomFrom(
	random(),
	() -> buildLiteralExpression(testCase),
	() -> buildDeepCopyOfFieldExpression(testCase),
	() -> buildFieldExpression(testCase)
	);

[elasticsearchmachine]

💔 Backport failed

Status	Branch	Result
❌	8.19	Commit could not be cherrypicked due to conflicts
❌	9.1	Commit could not be cherrypicked due to conflicts
❌	8.18	Commit could not be cherrypicked due to conflicts
❌	9.0	Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 134461

[ncordon]

💚 All backports created successfully

Status	Branch	Result
✅	9.1
✅	9.0
✅	8.19
✅	8.18

Questions ?

Please refer to the Backport tool documentation